Skip to content

fix(py): Fix pyproject.toml on fastapi plugin#5030

Merged
huangjeff5 merged 3 commits into
mainfrom
jh-fix-fastapi-pyproject
Mar 31, 2026
Merged

fix(py): Fix pyproject.toml on fastapi plugin#5030
huangjeff5 merged 3 commits into
mainfrom
jh-fix-fastapi-pyproject

Conversation

@huangjeff5
Copy link
Copy Markdown
Contributor

@huangjeff5 huangjeff5 commented Mar 30, 2026

This PR fixes a bug preventing the genkit-plugin-fastapi package from being uploaded to PyPI (returning a 400 Bad Request: Duplicate filename in local headers error)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the build configuration for the FastAPI plugin in pyproject.toml, specifically changing how files are included in the wheel distribution. A critical issue was identified where switching from packages to only-include would result in an incorrect file structure within the built wheel, breaking standard imports. The feedback suggests reverting to the packages configuration to maintain the correct namespace mapping.

Comment thread py/plugins/fastapi/pyproject.toml Outdated
@apascal07 apascal07 self-requested a review March 31, 2026 17:23
@huangjeff5 huangjeff5 merged commit cacbf57 into main Mar 31, 2026
21 checks passed
@huangjeff5 huangjeff5 deleted the jh-fix-fastapi-pyproject branch March 31, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants