wip: handle picking stroke of polygon layer#114
Open
kylebarron wants to merge 4 commits into
Open
Conversation
Member
Author
|
I think something like the last commit will be useful. Where we take a sequence of offsets and invert all of them at once. Then we should be able to perform a lookup based on the global index of the path layer. But this doesn't quite work yet. |
5 tasks
kylebarron
added a commit
to developmentseed/lonboard
that referenced
this pull request
Mar 28, 2024
It looks like this is now working! <img width="686" alt="image" src="https://github.com/developmentseed/lonboard/assets/15164633/91edc23d-0ecd-49c0-bf1e-0068a617a8fb"> This does have the caveat that picking currently only works for _polygons_ and not their associated exteriors. See geoarrow/deck.gl-geoarrow#114 Todo: - [x] Use PolygonLayer as the default polygon rendering in `viz` - [x] Render stroke by default in `viz`. - [ ] Get input from designers on good default colors for the Polygon exterior - [x] Document difference between the two polygon layers - [x] Use published @geoarrow/deck.gl-layers beta, instead of local install. Closes #197 ----- Old: It turns out that there are still some issues on the JS side of the PolygonLayer. I think I had only tested it with Polygon, not MultiPolygon, input, which is why I didn't catch these two. More info in geoarrow/deck.gl-geoarrow#102
roger120981
pushed a commit
to roger120981/lonboard
that referenced
this pull request
Jul 14, 2025
It looks like this is now working! <img width="686" alt="image" src="https://github.com/developmentseed/lonboard/assets/15164633/91edc23d-0ecd-49c0-bf1e-0068a617a8fb"> This does have the caveat that picking currently only works for _polygons_ and not their associated exteriors. See geoarrow/deck.gl-geoarrow#114 Todo: - [x] Use PolygonLayer as the default polygon rendering in `viz` - [x] Render stroke by default in `viz`. - [ ] Get input from designers on good default colors for the Polygon exterior - [x] Document difference between the two polygon layers - [x] Use published @geoarrow/deck.gl-layers beta, instead of local install. Closes developmentseed#197 ----- Old: It turns out that there are still some issues on the JS side of the PolygonLayer. I think I had only tested it with Polygon, not MultiPolygon, input, which is why I didn't catch these two. More info in geoarrow/deck.gl-geoarrow#102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to allow picking of both the underlying SolidPolygonLayer and the PathLayer.
In #113 we enable the picked index from the SolidPolygonLayer to be proxied to the consumer of the
PolygonLayer. This works because the data structure of the PolygonLayer is exactly the same as the data structure of the SolidPolygonLayer. And the SolidPolygonLayer handles the index conversions when rendering MultiPolygons to screen (ininvertOffsets).The thing is, with the PathLayer we need to apply
invertOffsetstwice. The PathLayer returns a single index into the expanded PathLayer table. But we need to map that back into the original polygon table passed in by the user.