Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds keybind modifier fallthrough for keybinds settings listeners. In reality this means that if the user presses something like CTRL+ALT+S, it will look for a match for CTRL+ALT+S, then for matches for CTRL+S and ALT+S and then for matches for just S. The search stops once a hit that doesn't propagate is found.
This PR is meant to bring the settings functionality more in line with user expectations from the vanilla game, where modifiers can modify the outcome of the action but they never prevent it from happening - Editor CTRL+A still moves the block to the left in vanilla, even though CTRL+D duplicates it. Another common complaint this would address is people being "unable to place checkpoints" when having their jump key bound to Left CTRL.
Lastly I'd like to mention that an alternate proposal also exists (also proposed by me) where instead of this being a default behavior there would be an explicit Any modifier defined for settings, which would explicitly make settings listen to the keybind regardless of the modifier. However, IMO, the behavior in this PR matches user expectations more.