Added color codes#2117
Open
SMJSProductions wants to merge 14 commits into
Open
Conversation
dankmeme01
requested changes
Jul 8, 2026
dankmeme01
left a comment
dankmeme01
left a comment
Member
There was a problem hiding this comment.
Aside from pending comments, there are some other things overall:
- While we aren't very consistent with it, most of the codebase doesn't add
constto all local variables, so it's best to remove that for clarity - Simpler functions should honestly just be in the header for consistency. Those with a larger body can stay in the .cpp file. I probs would've just made the entire class header-only so it doesn't add extra compile time to geode and allows for greater inlining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.