Fix missing configs in pip install and unregistered OmegaConf resolvers in tests#341
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 94.06% 94.06% -0.01%
==========================================
Files 207 206 -1
Lines 8730 8726 -4
==========================================
- Hits 8212 8208 -4
Misses 518 518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pyproject.toml: Added"configs"to[tool.setuptools.packages.find]and a[tool.setuptools.package-data]entry withconfigs = ["**/*.yaml"]so the Hydra config files are bundled when installing viapip install git+...test/_utils/simplified_pipeline.py: Replaced a stale, partial set of manualOmegaConf.register_new_resolver(...)calls with a singleregister_all_resolvers()calltest/utils/test_config_resolvers.py: Addedregister_all_resolvers()tosetup_methodbeforehydra.initialize()so all custom resolvers are available when Hydra composes configsFixes
configs/directory missing afterpip install git+...omegaconf.errors.UnsupportedInterpolationType: Unsupported interpolation type define_task_levelintest/pipeline/test_pipeline.pyomegaconf.errors.UnsupportedInterpolationType: Unsupported interpolation type set_preserve_edge_attrintest/utils/test_config_resolvers.py