Fix ADME dependencies#343
Merged
Merged
Conversation
…ic-intelligence/TopoBench into guille/configs_and_tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ADME dataset dependencies (
PyTDC,rdkit) lazy importstdcandogb.utils.molwere imported at the top ofadme_datasets.py, causingModuleNotFoundErrorwhen loading any dataset even if no ADME data was involved. Moved the imports insideload_dataset()behind atry/except ImportError, so they are only required when an ADME dataset is actually used and the error message clearly tells the user what to install.