Skip to content

Commit 4a62b30

Browse files
Applied some missing beans to config-security-openidconnect.xml (#9040)
The changes were applied to config-security-openidconnectbearer.xml in the following PR. But seems to have missed applying the changes in config-security-openidconnect.xml #8875 #8761 Co-authored-by: Ian Allen <ianwallen@hotmail.com>
1 parent a58b260 commit 4a62b30

1 file changed

Lines changed: 67 additions & 33 deletions

File tree

web/src/main/webapp/WEB-INF/config-security/config-security-openidconnect.xml

Lines changed: 67 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
~ Copyright (C) 2022 Food and Agriculture Organization of the
2+
~ Copyright (C) 2025 Food and Agriculture Organization of the
33
~ United Nations (FAO-UN), United Nations World Food Programme (WFP)
44
~ and United Nations Environment Programme (UNEP)
55
~
@@ -65,7 +65,7 @@
6565

6666
<bean id="openidconnectOAuth2AuthorizationRequestRedirectFilter" class="org.springframework.security.oauth2.client.web.OAuth2AuthorizationRequestRedirectFilter">
6767
<constructor-arg ref ="openidconnectAuthorizationRequestResolver" />
68-
</bean>
68+
</bean>
6969

7070

7171
<bean id ="openidconnectInMemoryOAuth2AuthorizedClientService" class="org.springframework.security.oauth2.client.InMemoryOAuth2AuthorizedClientService">
@@ -118,18 +118,6 @@
118118
<constructor-arg ref="openidconnectLogoutSuccessHandlerBase"/>
119119
</bean>
120120

121-
<bean id="oidcSessionRegistry" class="org.fao.geonet.kernel.security.openidconnect.oidclogout.InMemoryOidcSessionRegistry"/>
122-
<bean id="sessionAuthenticationStrategy"
123-
class="org.fao.geonet.kernel.security.openidconnect.oidclogout.OidcSessionRegistryAuthenticationStrategy"/>
124-
125-
<bean id="sessionMgmtFilter"
126-
class="org.springframework.security.web.session.SessionManagementFilter">
127-
<constructor-arg ref="securityContextRepository"/>
128-
<constructor-arg ref="sessionAuthenticationStrategy"/>
129-
</bean>
130-
<bean id="backchannellogoutFilter"
131-
class="org.fao.geonet.kernel.security.openidconnect.oidclogout.OidcBackchannelLogoutFilter"/>
132-
133121
<bean id="logoutFilter"
134122
class="org.springframework.security.web.authentication.logout.LogoutFilter">
135123
<constructor-arg ref="openidconnectLogoutSuccessHandler"/>
@@ -152,28 +140,74 @@
152140
<property name="filterProcessesUrl" value="/signout"/>
153141
</bean>
154142

143+
<bean id="sessionExpirationFilter" class="org.fao.geonet.kernel.security.openidconnect.SessionExpirationFilter"/>
144+
145+
<bean id="geonetworkOidcPreAuthActionsLoginFilter" class="org.fao.geonet.kernel.security.openidconnect.GeonetworkOidcPreAuthActionsLoginFilter"/>
146+
147+
<bean id="oAuth2Configuration" class="org.fao.geonet.kernel.security.openidconnect.OAuth2Configuration"/>
155148

156149
<bean id="filterChainFilters" class="java.util.ArrayList">
157-
<constructor-arg>
158-
<list>
159-
<ref bean="securityContextPersistenceFilter"/>
160-
<!-- To disable csrf security (not recommended) comment the following line -->
161-
<ref bean="csrfFilter" />
162-
<!-- To disable csrf security (not recommended) comment the upper line -->
163-
164-
<ref bean="openidconnectOAuth2AuthorizationRequestRedirectFilter"/>
165-
<ref bean="openidconnectOAuth2LoginAuthenticationFilter"/>
166-
<ref bean="backchannellogoutFilter"/>
167-
<ref bean="logoutFilter"/>
168-
169-
170-
<ref bean="requestCacheFilter"/>
171-
<ref bean="anonymousFilter"/>
172-
<ref bean="sessionMgmtFilter"/>
173-
<ref bean="exceptionTranslationFilter"/>
174-
<ref bean="filterSecurityInterceptor"/>
175-
</list>
150+
<constructor-arg
151+
ref="#{ openidconnectConfiguration.loginType == 'autologin' ? 'openidConnectFilterChanFiltersInclusive' : 'openidConnectFilterChanFiltersExclusive' }">
152+
176153
</constructor-arg>
177154
</bean>
178155

156+
<bean id="oidcSessionRegistry" class="org.fao.geonet.kernel.security.openidconnect.oidclogout.InMemoryOidcSessionRegistry"/>
157+
<bean id="sessionAuthenticationStrategy"
158+
class="org.fao.geonet.kernel.security.openidconnect.oidclogout.OidcSessionRegistryAuthenticationStrategy"/>
159+
160+
<bean id="sessionMgmtFilter"
161+
class="org.springframework.security.web.session.SessionManagementFilter">
162+
<constructor-arg ref="securityContextRepository"/>
163+
<constructor-arg ref="sessionAuthenticationStrategy"/>
164+
</bean>
165+
166+
<bean id="backchannellogoutFilter"
167+
class="org.fao.geonet.kernel.security.openidconnect.oidclogout.OidcBackchannelLogoutFilter">
168+
<constructor-arg ref="csrfFilter" />
169+
<constructor-arg ref="geonetworkCsrfSecurityRequestMatcher" />
170+
</bean>
171+
172+
<util:list id="openidConnectFilterChanFiltersExclusive">
173+
174+
<ref bean="securityContextPersistenceFilter"/>
175+
<!-- To disable csrf security (not recommended) comment the following line -->
176+
<ref bean="csrfFilter" />
177+
<!-- To disable csrf security (not recommended) comment the upper line -->
178+
179+
<ref bean="openidconnectOAuth2AuthorizationRequestRedirectFilter"/>
180+
<ref bean="openidconnectOAuth2LoginAuthenticationFilter"/>
181+
<ref bean="backchannellogoutFilter"/>
182+
<ref bean="logoutFilter"/>
183+
184+
185+
<ref bean="requestCacheFilter"/>
186+
<ref bean="anonymousFilter"/>
187+
<ref bean="sessionMgmtFilter"/>
188+
<ref bean="exceptionTranslationFilter"/>
189+
<ref bean="filterSecurityInterceptor"/>
190+
191+
</util:list>
192+
193+
<util:list id="openidConnectFilterChanFiltersInclusive">
194+
195+
<ref bean="securityContextPersistenceFilter"/>
196+
<ref bean="csrfFilter" />
197+
198+
<ref bean="openidconnectOAuth2AuthorizationRequestRedirectFilter"/>
199+
<ref bean="openidconnectOAuth2LoginAuthenticationFilter"/>
200+
<ref bean="backchannellogoutFilter"/>
201+
<ref bean="logoutFilter"/>
202+
<ref bean="sessionExpirationFilter"/>
203+
<!-- include a pre login filter-->
204+
<ref bean="geonetworkOidcPreAuthActionsLoginFilter"/>
205+
206+
<ref bean="requestCacheFilter"/>
207+
<ref bean="anonymousFilter"/>
208+
<ref bean="sessionMgmtFilter"/>
209+
<ref bean="exceptionTranslationFilter"/>
210+
<ref bean="filterSecurityInterceptor"/>
211+
212+
</util:list>
179213
</beans>

0 commit comments

Comments
 (0)