Fix isReviewer in manage record menu (#9271)

* Fix isReviewer in manage record menu

* Fix js error and method parameters

Author: tylerjmchugh

web-ui/src/main/resources/catalog/components/toolbar/ToolbarDirective.js

@@ -310,7 +310,7 @@
               return true;
             }
 
-            var statusEffects = scope.getStatusEffects(user);
+            var statusEffects = scope.getStatusEffects();
             for (var i = 0; i < statusEffects.length; i++) {
               if (scope.displayWorkflowStepOption(statusEffects[i], user)) {
                 return true;
@@ -320,10 +320,28 @@
             return false;
           };
 
-          scope.getStatusEffects = function (user) {
-            var isReviewer =
-              user.isAdmin() || user.isReviewerForGroup(scope.md.groupOwner);
-            return scope.statusEffects[isReviewer ? "reviewer" : "editor"];
+          scope.getStatusEffects = function () {
+            return scope.statusEffects[scope.isReviewer() ? "reviewer" : "editor"];
+          };
+
+          scope.isReviewer = function () {
+            return (
+              scope.user &&
+              (scope.user.isAdmin() ||
+                (scope.md &&
+                  scope.md.groupOwner &&
+                  scope.user.isReviewerForGroup(scope.md.groupOwner)))
+            );
+          };
+
+          scope.getWorkflowStepLabelKey = function (step) {
+            return (
+              step.from +
+              "-to-" +
+              step.to +
+              "-" +
+              (scope.isReviewer() ? "reviewer" : "editor")
+            );
           };
 
           scope.displayEnableWorkflowOption = function (user) {

web-ui/src/main/resources/catalog/components/toolbar/partials/menu-manage-record.html

@@ -12,11 +12,7 @@
     <span data-translate="" class="hidden-xs">manageRecord</span>
     <span class="caret"></span>
   </button>
-  <ul
-    class="dropdown-menu"
-    role="menu"
-    data-ng-init="isReviewer = user.isAdmin() || user.isReviewerForGroup(md.groupOwner);"
-  >
+  <ul class="dropdown-menu" role="menu">
     <li role="menuitem" data-ng-if="showBatchDropdown">
       <label>
         <input
@@ -107,17 +103,17 @@
       </a>
     </li>
     <li
-      data-ng-repeat="step in getStatusEffects(user)"
+      data-ng-repeat="step in getStatusEffects()"
       data-ng-show="displayWorkflowStepOption(step, user)"
     >
       <a
         href=""
-        data-ng-init="stepLabelKey = step.from + '-to-' + step.to + '-' + (isReviewer ? 'reviewer' : 'editor')"
         data-ng-click="mdService.openUpdateStatusPanel(
-                          getScope(), 'workflow', null, status[step.to], stepLabelKey)"
+                          getScope(), 'workflow', null, status[step.to],
+                          getWorkflowStepLabelKey(step))"
       >
-        <span class="fa fa-fw gn-status-{{stepLabelKey}}"></span>&nbsp;
-        <span>{{('mdStatusTitle-' + stepLabelKey) | translate}}</span>
+        <span class="fa fa-fw gn-status-{{getWorkflowStepLabelKey(step)}}"></span>&nbsp;
+        <span>{{('mdStatusTitle-' + getWorkflowStepLabelKey(step)) | translate}}</span>
       </a>
     </li>