OIDC Improvements and bug fixes#8761
Merged
Merged
Conversation
davidblasby
approved these changes
Apr 25, 2025
| import java.io.IOException; | ||
| import java.net.URLEncoder; | ||
|
|
||
| public class GeonetworkOidcPreAuthActionsLoginFilter implements Filter { |
Contributor
There was a problem hiding this comment.
please add javadoc to explain what this is doing
Contributor
Author
There was a problem hiding this comment.
Java docs added
josegar74
reviewed
Apr 29, 2025
| @@ -0,0 +1,41 @@ | |||
| package org.fao.geonet.kernel.security.openidconnect; | |||
| @@ -0,0 +1,85 @@ | |||
| package org.fao.geonet.kernel.security.openidconnect; | |||
Collaborator
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8761-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ef51c8b24699beadab1b021b3bd4a24924a21889,189bce83a5dd38c29b513133fe4bdc0d2883c0dd,c00fb2c366b0550ae1b327f25caf38ef680b8099,1deff2b019c71db748c6a8d67c6f3dd2b91d47ca,050e6a0a11e80a4ad81dfcd46073dc49ecb3fda7,b2eae4d9d552c9f5c92db588e7a40432c09ec1ae,39001dbb142dc64d3fd212cce8f0c691aa3c2bdd
# Push it to GitHub
git push --set-upstream origin backport-8761-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.xThen, create a pull request where the |
ianwallen
pushed a commit
to ianwallen/core-geonetwork
that referenced
this pull request
Apr 29, 2025
Added pre-login filter to enable autologin, and restrict guest users Added configuration for a OAuth2AuthorizedClientManager, which enables refreshing access token Fixed the check for setting the userNameAttribute in GeonetworkOidcUserService.java and the Client Registration UserNameAttribute configuration in GeonetworkClientRegistrationProvider.java to based on OIDCConfig Update the postLogoutRedirect endpoint to exclude default port numbers * Update AudienceAccessTokenValidator.java Fix logic * oidc fix * remove @configuration in OAuth2Config * add license file header
ianwallen
added a commit
that referenced
this pull request
Apr 29, 2025
Added pre-login filter to enable autologin, and restrict guest users Added configuration for a OAuth2AuthorizedClientManager, which enables refreshing access token Fixed the check for setting the userNameAttribute in GeonetworkOidcUserService.java and the Client Registration UserNameAttribute configuration in GeonetworkClientRegistrationProvider.java to based on OIDCConfig Update the postLogoutRedirect endpoint to exclude default port numbers * Update AudienceAccessTokenValidator.java Fix logic * oidc fix * remove @configuration in OAuth2Config * add license file header Co-authored-by: xiechangning20 <59653172+xiechangning20@users.noreply.github.com>
10 tasks
ianwallen
added a commit
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pre-login filter to enable autologin, and restrict guest users
Added configuration for a OAuth2AuthorizedClientManager, which enables refreshing access token
Fixed the check for setting the userNameAttribute in GeonetworkOidcUserService.java and the Client Registration UserNameAttribute configuration in GeonetworkClientRegistrationProvider.java to based on OIDCConfig
Update the postLogoutRedirect endpoint to exclude default port numbers
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation