Fix md is null in record view#8768
Merged
ianwallen merged 4 commits intoMay 6, 2025
Merged
Conversation
Collaborator
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8768-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b4733406e8f39ab9329ed06db5b0339a22d6e512,42646a33b42f41de312429fee3869f2d7c4d54f7,e7a505353a0c2fdc88fb9ea7f749bb9d1e10bc97,8b6c0ec7ccc49cfc64c1103c289e8ffafe4c93c0
# Push it to GitHub
git push --set-upstream origin backport-8768-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.xThen, create a pull request where the |
tylerjmchugh
added a commit
to tylerjmchugh/core-geonetwork
that referenced
this pull request
May 6, 2025
* Change md to mdView.current.record * Add isMdWorkflowEnable to GnMdViewController * Refactor recordviewMenu * Whitespace/layout (cherry picked from commit bd4d148)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #7802 the
mdobject is not set in therecordViewtemplate. The reason is thatgnMdActionsMenuset themdobject and now it is in a different scope.This causes several issues:
The working copy link is broken (UUID is missing):

The record links are not shown:

The status label is not shown:

This PR aims to fix this issue by changing the template and sub templates to use
mdView.current.recordinstead ofmd. With the changes from this PR all three of these issues are fixed.Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation