Configuration options discovered from source (documentation change suggestions)#9110
Configuration options discovered from source (documentation change suggestions)#9110ZakarFin wants to merge 5 commits into
Conversation
| Alternative environment variables are also supported for non-container (WAR-file) environments: | ||
|
|
||
| ``` text | ||
| GEONETWORK_DB_USERNAME=example |
There was a problem hiding this comment.
I would document also GEONETWORK_DB_TYPE
There was a problem hiding this comment.
There's a comment on the pom.xml that GEONETWORK_DB_TYPE could be set with env variables, but I'm not sure if that is true. It's handled differently and can be set with the Java System property that is the other suggested change to this file on the pull request. It's been a while so I can't remember if I actually tested, but I'm not sure how it would work based on the current pom.xml. It's probably done differently on the pom.xml to have a reasonable default value if nothing is passed with env.
There was a problem hiding this comment.
@ZakarFin GEONETWORK_DB_TYPE is used and works (you have an example in the official docker repo).
When both java system property -Dgeonetwork.db.type and GEONETWORK_DB_TYPE are set, the java property (-D) takes precedence and is used.
There was a problem hiding this comment.
Nice 👍 maybe it's handled in other way than the other related ENVs since couldn't find it with the rest of the ENVs. I'll add it when I get the chance 👍
Co-authored-by: Jose García <josegar74@gmail.com>
Co-authored-by: Jose García <josegar74@gmail.com>
| curl -X PUT http://localhost:9200/gn-features -H 'Content-Type: application/json' -d @features.json | ||
| curl -X PUT http://localhost:9200/gn-records -H 'Content-Type: application/json' -d @records.json | ||
| curl -X PUT http://localhost:9200/gn-searchlogs -H 'Content-Type: application/json' -d @searchlogs.json | ||
| ``` |
There was a problem hiding this comment.
These are based on
Lines 1607 to 1611 in e8cee08
|
@ZakarFin I'm going to leave this PR unmerged for now because we don't necessarily need it for the upcoming release; let me know when you've added |
|
Added the mention of GEONETWORK_DB_TYPE. Couldn't really track where it's handled but didn't see any special handling for it in the Dockerfile either -> should work on non-containerized installs as well :) |
PascalLike
left a comment
PascalLike
left a comment
There was a problem hiding this comment.
Looks good now, thanks
6 participants
Apparently documentation has moved to the main repository so I'm suggesting the changes made in geonetwork/doc#248 to be migrated to this documentation. We've been tinkering with GeoNetwork migration from 3.x to 4.x for some time now and looking at the code I noticed these configuration options as well. Also noticed that the indexes are by default prefixed with
gn-(https://github.com/geonetwork/core-geonetwork/blob/4.2.13/pom.xml#L1565-L1569).I'm not sure if you want to have links to source code in the documentation or if the defaults are different in the prepackaged versions of WAR-file or the Containerized setup. These are the ones that are defaulted when building from source. As we are migrating to 4.2.x before continuing to go for 4.4.x things might have changed, but at least raising awareness for someone more experienced with GN to take a look at the docs.
Maybe also take a look at this: geonetwork/doc#249 as it seems the path to
encryptor.propertieson the docs was wrong (in our experience).Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation