Fix isReviewer in manage record menu

[tylerjmchugh]

Currently, the manage record menu initializes some record-dependent values in the template using ng-init.

This pattern already existed before #9254 which split the record actions menu into separate manage and download menus. However, that split changed the timing of when the manage menu template is created.

Before the split, the relevant menu content was still guarded inside the original template by an ng-if, so ng-init usually ran only after md had already been set. After the split, the manage menu is now its own directive and the template can be linked before the directive has finished setting its local md value.

As a result, the reviewer state can be initialized incorrectly. When logged in as a reviewer, the workflow step label key is built with the -editor suffix instead of -reviewer. Those translation/status keys do not exist for reviewer-only workflow steps, so the workflow actions are not displayed correctly. When logged in as an editor, the actions do not show, which is expected. When logged in as an administrator, the actions still show correctly because isReviewer is initialized correctly from user.isAdmin().

This PR aims to fix the regression introduced by the menu split by removing the record-dependent ng-init usage and calculating the reviewer state and workflow step label key from the current directive scope instead.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

[josegar74]

I see the following error in the Javascript console:

angular.js?v=54a909cc6308f9989690b07aedc2e7ead0fe849a:15697 TypeError: Cannot read properties of undefined (reading 'groupOwner')
    at scope.isReviewer (ToolbarDirective.js:329:78)
    at scope.getStatusEffects (ToolbarDirective.js:324:46)
    at scope.anyWorkflowOptionDisplayed (ToolbarDirective.js:313:39)

Complaints about scope.md.groupOwner in https://github.com/geonetwork/core-geonetwork/pull/9271/changes#diff-2a3359d9bd35129adf44d18ec994584f8e22dbfaf3e41dcb1b58cb87b47b1547R329

[josegar74]

Please check https://github.com/geonetwork/core-geonetwork/pull/9271/changes#diff-2a3359d9bd35129adf44d18ec994584f8e22dbfaf3e41dcb1b58cb87b47b1547L313, it still calls the method with the user parameter.

[tylerjmchugh]

Fixed in latest push