rewrite viz section#248
Conversation
pvgenuchten
commented
Jun 23, 2026
pvgenuchten
commented
- update with timisoara data
- revert cog in ol, agree with just, it is not timely
pvgenuchten
force-pushed
the
rewrite-viz-revert-cog-ol
branch
2 times, most recently
from
eeaf3e9 to
258d2ad
Compare
|
@pvgenuchten - I was about to create an issue that the pydeck example was broken for me when testing with the latest Docker image - but you have addressed this in this PR. |
| "\n", | ||
| "# Create cluster layer\n", | ||
| "m.add(MarkerCluster(markers=markers, disable_clustering_at_zoom=16))\n", | ||
| "m" |
There was a problem hiding this comment.
is this m required? It does not throw an error, but it still runs when removing it.
There was a problem hiding this comment.
m prints the actual map, ah so m is not needed, maybe m.add already prints it (jupyter plots any content which is returned by the last statement, in this case m)
There was a problem hiding this comment.
actually, because in quite cases the m variable (for map) is reused, there is a bit unexpected behaviour if you don't explicitely call the m finally. maybe more explicit use display(m) is more understandable...
There was a problem hiding this comment.
Ah ok - it seemed fine to remove when I tested, but a comment above saying it will display is also fine
| "</script>\n", | ||
| "''')\n", | ||
| "\n" | ||
| "gdal.Warp('../data/output/world_3857_cog.tif','../data/world.rgb.tif',dstSRS='EPSG:3857',format='COG')\n" |
There was a problem hiding this comment.
I get a couple of warnings here that it might be good to explain? Warning 1: Clamping output bounds to (-20037508.342789,-20037508.342789) -> (20037508.342789, 20037508.342789) Warning 1: Clamping output bounds to (-20037508.342789,-20037508.342789) -> (20037508.342789, 20037508.342789)
There was a problem hiding this comment.
apparently when you warp -180,90 this error occurs, limiting to -180,85...
pvgenuchten
force-pushed
the
rewrite-viz-revert-cog-ol
branch
3 times, most recently
from
856011c to
16d2bd7
Compare
revert cog in ol, agree with just, it is not timely
pvgenuchten
force-pushed
the
rewrite-viz-revert-cog-ol
branch
from
16d2bd7 to
ee1c243
Compare
|
rebased to master |
2 participants
