Skip to content

Update .gitignore list#251

Merged
pvgenuchten merged 2 commits into
geopython:masterfrom
geographika:gitignore
Jun 23, 2026
Merged

Update .gitignore list#251
pvgenuchten merged 2 commits into
geopython:masterfrom
geographika:gitignore

Conversation

@geographika

Copy link
Copy Markdown

Fixes #250
Also ignores changed output generated in #228 and 10-populated-places-ba.json (which is not in the repo but generated when working through the notebook).

@justb4 justb4 self-requested a review June 23, 2026 11:11

@justb4 justb4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to coordinate with @pvgenuchten for the COG file:

  • check the name
  • or better: I suggest to create an output dir under notebooks and place a .gitkeep file there and maybe even write all generated output there (iso in test) then with one "catchall" .gitignore rule, . See data/output, similar.

@geographika

Copy link
Copy Markdown
Author

This PR is just to update the current approach. Writing all outputs to a single directory makes sense, but some Notebook outputs are checked-in to the repo, others are in different locations, so these would all need to be reviewed. Probably not something to do within hours of freezing development.

@pvgenuchten - please check that the COG file generated in #248 matches the name here (or feel free to update with a new location).

@pvgenuchten

pvgenuchten commented Jun 23, 2026

Copy link
Copy Markdown

agree to prevent file creation in other then ../data/output
however in some cases these files need to be hosted, which is currently not possible in ../data
i'm moving away from the cog in openlayers sample, it came too early in the workshop

@pvgenuchten pvgenuchten merged commit c4afd6a into geopython:master Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

05-raster: Prevent the COG file being committed/pushed

3 participants