fix API deletion on not found items in backend

Author: tomkralidis

pygeoapi/api/itemtypes.py

@@ -59,7 +59,8 @@
 from pygeoapi.openapi import get_oas_30_parameters
 from pygeoapi.plugin import load_plugin, PLUGINS
 from pygeoapi.provider.base import (
-    ProviderGenericError, ProviderTypeError, SchemaType)
+    ProviderGenericError, ProviderItemNotFoundError,
+    ProviderTypeError, SchemaType)
 
 from pygeoapi.util import (filter_providers_by_type, to_json,
                            filter_dict_by_key_value, str2bool,
@@ -834,6 +835,13 @@ def manage_collection_item(
 
     if action == 'delete':
         LOGGER.debug('Deleting item')
+        try:
+            _ = p.get(identifier)
+        except ProviderItemNotFoundError as err:
+            return api.get_exception(
+                err.http_status_code, headers, request.format,
+                err.ogc_exception_code, err.message)
+
         try:
             _ = p.delete(identifier)
         except ProviderGenericError as err:

tests/provider/test_postgresql_provider.py

@@ -892,6 +892,13 @@ def test_transaction_basic_workflow(pg_api_, data):
         identifier=123)
     assert code == HTTPStatus.OK
 
+    # delete again (item should not be in backend)
+    req = mock_api_request(data=data)
+    headers, code, content = manage_collection_item(
+        pg_api_, req, action='delete', dataset='hot_osm_waterways',
+        identifier=123)
+    assert code == HTTPStatus.BAD_REQUEST
+
 
 def test_transaction_create_handles_invalid_input_data(pg_api_, data):
     data_parsed = json.loads(data)