What is the purpose of WPSRequest.identifiers?

[cehbrecht]

Description

In the WPSRequest class we have the members identifier and identifiers:

pywps/pywps/app/WPSRequest.py

Line 40 in 34b06f4

self.identifiers = None

Looks like identifiers is a left over and a potential bug.

Steps to Reproduce

Additional Information

See also PR #330 and WPSRequest tests:

pywps/tests/test_wpsrequest.py

Line 33 in 91da95e

'identifiers': 'ahoj', # TODO: why identifierS?

[cehbrecht]

The identifier member was added by PR #312 by @elemoine.

[ldesousa]

Yep, looks fishy. self.identifier is only used in the JSON serialisation. Will take a closer look over the weekend.

[elemoine]

The identifier member was added by PR #312 by @elemoine.

That is not quite right :) WPSRequest.identifier was already there, but it was not serialized by the json property. I can provide more details if needed.

[cehbrecht]

@elemoine
Some light on that code part would be nice :)

It didn't go through the code yet but I have the feeling that there should be only WPSRequest.identifier. So we need to refactor and fix the code to get rid of the extra identifierS.

[ldesousa]

@elemoine but is it being used for something?