fix: graceful test skipping, new unit tests, ESLint/package config improvements

georgeglarson · claude · georgeglarson · commit d050f5bb9f81 · 2026-03-12T21:41:29.000Z
- Migrate 9 integration tests to describeWithEnvironmentCheck() for graceful
  skipping instead of throwing errors when API keys are missing
- Add 178 new unit tests: event-manager (25), error types (84), error
  factory (35), sanitizer (34) — total now 998 passing
- Add "type": "module" to package.json (eliminates Node.js warning)
- Relax ESLint rules for test files (no-explicit-any, no-non-null-assertion,
  no-unused-vars off in *.test.ts and __integration__)
- Fix collectStream timeout promise leak (clearTimeout on success)
- Zero ESLint warnings, zero test failures, zero type errors

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/venice-ai-sdk/packages/core/eslint.config.js b/venice-ai-sdk/packages/core/eslint.config.js
@@ -27,6 +27,14 @@ export default [
       '@typescript-eslint/no-non-null-assertion': 'warn'
     }
   },
+  {
+    files: ['**/*.test.ts', '**/__integration__/**'],
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+    },
+  },
   {
     ignores: ['dist/**', 'node_modules/**', '*.config.js', '*.config.ts']
   }
diff --git a/venice-ai-sdk/packages/core/package.json b/venice-ai-sdk/packages/core/package.json
@@ -1,6 +1,7 @@
 {
   "name": "@venice-dev-tools/core",
   "version": "2025.12.4",
+  "type": "module",
   "description": "Core package for the Venice AI unOfficial SDK",
   "main": "./dist/index.cjs",
   "module": "./dist/index.mjs",
diff --git a/venice-ai-sdk/packages/core/src/__integration__/api-keys.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/api-keys.integration.test.ts
@@ -1,20 +1,14 @@
-import { describe, it, expect, beforeAll, afterAll } from 'vitest';
+import { it, expect, beforeAll, afterAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('API Keys Integration Tests', () => {
+describeWithEnvironmentCheck('API Keys Integration Tests', () => {
   let venice: VeniceAI;
   let createdKeyId: string;
   let testApiKey: string;
   let hasAdminPermissions = false;
 
   beforeAll(async () => {
-    // Check environment first
-    const env = checkTestEnvironment(true); // require admin key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.adminApiKey!,
@@ -310,4 +304,4 @@ describe('API Keys Integration Tests', () => {
       console.error('Error during cleanup:', error);
     }
   });
-});
+}, true);
diff --git a/venice-ai-sdk/packages/core/src/__integration__/audio.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/audio.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Audio Integration Tests', () => {
+describeWithEnvironmentCheck('Audio Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/billing.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/billing.integration.test.ts
@@ -1,18 +1,12 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Billing Integration Tests', () => {
+describeWithEnvironmentCheck('Billing Integration Tests', () => {
   let venice: VeniceAI;
   let hasAdminPermissions = false;
 
   beforeAll(async () => {
-    // Check environment first
-    const env = checkTestEnvironment(true); // require admin key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.adminApiKey!,
@@ -372,4 +366,4 @@ describe('Billing Integration Tests', () => {
       venice.billing.getUsage({ limit: 1000 }) // Exceeds max limit
     ).rejects.toThrow();
   }, 30000);
-});
+}, true);
diff --git a/venice-ai-sdk/packages/core/src/__integration__/characters.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/characters.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Characters Integration Tests', () => {
+describeWithEnvironmentCheck('Characters Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/chat.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/chat.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Chat Integration Tests', () => {
+describeWithEnvironmentCheck('Chat Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/embeddings.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/embeddings.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Embeddings Integration Tests', () => {
+describeWithEnvironmentCheck('Embeddings Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/error-handling.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/error-handling.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Error Handling Integration Tests', () => {
+describeWithEnvironmentCheck('Error Handling Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/images.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/images.integration.test.ts
@@ -1,20 +1,14 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 import fs from 'fs';
 import path from 'path';
 
-describe('Images Integration Tests', () => {
+describeWithEnvironmentCheck('Images Integration Tests', () => {
   let venice: VeniceAI;
   let testImageBuffer: Buffer;
 
   beforeAll(async () => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/models.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/models.integration.test.ts
@@ -1,17 +1,11 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Models Integration Tests', () => {
+describeWithEnvironmentCheck('Models Integration Tests', () => {
   let venice: VeniceAI;
 
   beforeAll(() => {
-    // Check environment first
-    const env = checkTestEnvironment(false); // require regular API key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.apiKey!,
diff --git a/venice-ai-sdk/packages/core/src/__integration__/web3.integration.test.ts b/venice-ai-sdk/packages/core/src/__integration__/web3.integration.test.ts
@@ -1,18 +1,12 @@
-import { describe, it, expect, beforeAll } from 'vitest';
+import { it, expect, beforeAll } from 'vitest';
 import { VeniceAI } from '../venice-ai';
-import { getTestConfig, checkTestEnvironment } from './test-config';
+import { getTestConfig, describeWithEnvironmentCheck } from './test-config';
 
-describe('Web3 Integration Tests', () => {
+describeWithEnvironmentCheck('Web3 Integration Tests', () => {
   let venice: VeniceAI;
   let hasAdminPermissions = false;
 
   beforeAll(async () => {
-    // Check environment first
-    const env = checkTestEnvironment(true); // require admin key
-    if (env.skipTests) {
-      throw new Error(env.skipReason);
-    }
-
     const config = getTestConfig();
     venice = new VeniceAI({
       apiKey: config.adminApiKey!,
@@ -427,4 +421,4 @@ describe('Web3 Integration Tests', () => {
       expect(error).toBeDefined();
     }
   }, 30000);
-});
+}, true);
diff --git a/venice-ai-sdk/packages/core/src/errors/error-types.test.ts b/venice-ai-sdk/packages/core/src/errors/error-types.test.ts
diff --git a/venice-ai-sdk/packages/core/src/errors/factory/error-factory.test.ts b/venice-ai-sdk/packages/core/src/errors/factory/error-factory.test.ts
diff --git a/venice-ai-sdk/packages/core/src/events/event-manager.test.ts b/venice-ai-sdk/packages/core/src/events/event-manager.test.ts
diff --git a/venice-ai-sdk/packages/core/src/http/components/sanitizer.test.ts b/venice-ai-sdk/packages/core/src/http/components/sanitizer.test.ts
diff --git a/venice-ai-sdk/packages/core/src/utils/stream-helpers.ts b/venice-ai-sdk/packages/core/src/utils/stream-helpers.ts

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,14 @@ export default [`
`27`	`27`	`'@typescript-eslint/no-non-null-assertion': 'warn'`
`28`	`28`	`}`
`29`	`29`	`},`
	`30`	`+ {`
	`31`	`+ files: ['*/.test.ts', '/__integration__/'],`
	`32`	`+ rules: {`
	`33`	`+ '@typescript-eslint/no-explicit-any': 'off',`
	`34`	`+ '@typescript-eslint/no-non-null-assertion': 'off',`
	`35`	`+ '@typescript-eslint/no-unused-vars': 'off',`
	`36`	`+ },`
	`37`	`+ },`
`30`	`38`	`{`
`31`	`39`	`ignores: ['dist/', 'node_modules/', '.config.js', '.config.ts']`
`32`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@venice-dev-tools/core",`
`3`	`3`	`"version": "2025.12.4",`
	`4`	`+ "type": "module",`
`4`	`5`	`"description": "Core package for the Venice AI unOfficial SDK",`
`5`	`6`	`"main": "./dist/index.cjs",`
`6`	`7`	`"module": "./dist/index.mjs",`