[BUGFIX] Replace removed StandaloneView with ViewFactoryInterface for TYPO3 v14#254
Open
butu wants to merge 1 commit into
Open
[BUGFIX] Replace removed StandaloneView with ViewFactoryInterface for TYPO3 v14#254butu wants to merge 1 commit into
butu wants to merge 1 commit into
Conversation
… TYPO3 v14 StandaloneView has been removed in TYPO3 v14, causing a fatal error 'TYPO3\CMS\Fluid\View\StandaloneView not found' whenever the monitoring tried to send notification emails (client connection failure, admin report, client report). Use ViewFactoryInterface with ViewFactoryData instead, which is the v14 standard way to build fluid views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StandaloneViewhas been removed in TYPO3 v14 (was deprecated in v13). The monitoring extension still uses it inEmailNotification::getFluidTemplate(), which results in a fatal errorevery time a notification email is about to be sent:
ClientImport::run()→sendClientFailedEmail()(client connection failure)reporting:admin→sendAdminEmail()reporting:client→sendClientEmail()As a consequence the import run aborts and no warning email is sent at all.
Solution
Switch
getFluidTemplate()to the v14 standard view API:TYPO3\\CMS\\Core\\View\\ViewFactoryInterface(resolved viaGeneralUtility::makeInstance(), consistent with the existing non-DI instantiation ofEmailNotification)TYPO3\\CMS\\Core\\View\\ViewFactoryDatawithtemplatePathAndFilename+formatBehavior is unchanged: same templates, same format (txt), same assignments.
Notes
FluidViewFactory.Upgrade v14 todosection from the README.