Skip to content

Commit 5a6540a

Browse files
authored
fix: remove hardCoded varsion (#12498)
1 parent 8ae5df1 commit 5a6540a

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

web/client/utils/PrintUtils.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,6 @@ export const specCreators = {
778778
...getWMSLegendConfig({layer, legendOptions, mapBbox: spec.bbox, mapSize: spec.size, projection: spec.projection, format: LEGEND_FORMAT.IMAGE}),
779779
TRANSPARENT: true,
780780
EXCEPTIONS: "application/vnd.ogc.se_xml",
781-
VERSION: "1.1.1",
782781
SCALE: spec.scale,
783782
...getLegendIconsSize(spec, layer),
784783
...(spec.language ? {LANGUAGE: spec.language} : {})

web/client/utils/__tests__/PrintUtils-test.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,18 @@ describe('PrintUtils', () => {
526526
done();
527527
}).catch(done);
528528
});
529+
it('wms layer generation for legend includes only the layer version', (done) => {
530+
getMapfishLayersSpecification([{...layer, version: "1.3.0"}], { projection: "EPSG:3857" }, {}, 'legend').then(specs => {
531+
expect(specs).toExist();
532+
expect(specs.length).toBe(1);
533+
const legendUrl = specs[0].classes[0].icons[0];
534+
// Count both version and VERSION query parameters.
535+
const versionParams = legendUrl.match(/[?&]version=/gi) || [];
536+
expect(versionParams.length).toBe(1);
537+
expect(legendUrl.indexOf('version=1.3.0')).toBeGreaterThan(0);
538+
done();
539+
}).catch(done);
540+
});
529541
it('vector layer default point style', () => {
530542
const style = getOlDefaultStyle({ features: [{ geometry: { type: "Point" } }] });
531543
expect(style).toExist();

0 commit comments

Comments
 (0)