Support enable/disable rules on request configuration rules#12702
Open
offtherailz wants to merge 1 commit into
Open
Support enable/disable rules on request configuration rules#12702offtherailz wants to merge 1 commit into
offtherailz wants to merge 1 commit into
Conversation
Each entry in requestsConfigurationRules (and legacy authenticationRules)
can now set enabled to a boolean or a plugin expression string, evaluated
the same way as cfg.disablePluginIf (e.g. via state('usergroups')). Lets
an auth/header rule apply only to matching user groups.
Member
|
Converted to draft waiting for 2026.02.00 to be out |
tdipisa
marked this pull request as ready for review
July 22, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12704
Summary
requestsConfigurationRules(and legacyauthenticationRules) can now declare anenabledproperty: a plain boolean or a plugin expression string (same syntax ascfg.disablePluginIf), e.g."{includes(state('usergroups'), 'editor')}".enabledkeep the current behaviour (always applied).PluginsUtils.handleExpression/getMonitoredStatemachinery, no new expression syntax introduced.local-config.md.Test plan
SecurityUtils-test.js: noenabledproperty,enabled: false, expression resolving false, expression resolving true againststate('usergroups').SecurityUtils-test.jssuite locally via karma (chrome headless) — 59/59 passing, no regressions.