Skip to content

Commit 8a7c611

Browse files
committed
hostname: use missing
1 parent 1f96077 commit 8a7c611

7 files changed

Lines changed: 12 additions & 12 deletions

File tree

+stdlib/+dotnet/hostname.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
n = char(System.Net.Dns.GetHostName());
1010
catch e
1111
dotnetException(e);
12-
n = '';
12+
n = missing;
1313
end
1414

1515
% https://learn.microsoft.com/en-us/dotnet/api/system.net.dns.gethostname

+stdlib/+java/hostname.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
n = char(java.net.InetAddress.getLocalHost().getHostName());
55
catch e
66
javaException(e);
7-
n = '';
7+
n = missing;
88
end
99

1010
end

+stdlib/+python/hostname.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
n = char(py.socket.gethostname());
55
catch e
66
pythonException(e)
7-
n = '';
7+
n = missing;
88
end
99

1010
end

+stdlib/+shell/hostname.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
function [n, cmd] = hostname()
22

3+
n = missing;
4+
35
cmd = 'hostname';
4-
[s, n] = system(cmd);
6+
[s, r] = system(cmd);
57

68
if s == 0
7-
n = deblank(n);
8-
else
9-
n = '';
9+
n = deblank(r);
1010
end
1111

1212
end

+stdlib/hostname.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
backend (1,:) string = ["java", "dotnet", "python", "shell"]
1414
end
1515

16-
r = '';
16+
r = missing;
1717

1818
for b = backend
1919
switch b
@@ -31,7 +31,7 @@
3131
error('stdlib:hostname:ValueError', 'Unknown backend: %s', b)
3232
end
3333

34-
if ~isempty(r)
34+
if ~ismissing(r)
3535
return
3636
end
3737
end

test/TestBackend.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function test_backend(tc)
8484

8585
[i, b] = stdlib.hostname();
8686
tc.assertThat(b, IsSubsetOf(stdlib.Backend('hostname').backends))
87-
tc.verifyNotEmpty(i)
87+
tc.verifyClass(i, 'char')
8888

8989
[i, b] = stdlib.inode(readme);
9090
tc.assertThat(b, IsSubsetOf(stdlib.Backend('inode').backends))

test/TestSys.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ function test_checkRAM(tc)
7878
function test_hostname(tc, B_jdps)
7979
[h, b] = stdlib.hostname(B_jdps);
8080
tc.assertMatches(b, B_jdps)
81-
tc.verifyClass(h, 'char')
8281

8382
if ismember(B_jdps, stdlib.Backend().select('hostname'))
83+
tc.verifyClass(h, 'char')
8484
tc.verifyGreaterThan(strlength(h), 0)
8585
else
86-
tc.verifyEmpty(h)
86+
tc.verifyEqual(h, missing)
8787
end
8888
end
8989

0 commit comments

Comments
 (0)