Skip to content

Commit fefea51

Browse files
committed
perl_exe: use missing
1 parent e97ce40 commit fefea51

10 files changed

Lines changed: 14 additions & 18 deletions

File tree

+stdlib/+perl/get_uid.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
end
99

1010
exe = stdlib.perl_exe();
11-
if stdlib.strempty(exe)
11+
if ismissing(exe)
1212
return
1313
end
1414

+stdlib/+perl/is_admin.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@
1111
y = missing;
1212

1313
exe = stdlib.perl_exe();
14-
if stdlib.strempty(exe)
14+
if ismissing(exe)
1515
return
1616
end
1717

1818
cmd = sprintf('"%s" -e "%s"', exe, c);
1919

2020
[s, m] = system(cmd);
2121

22-
y = s == 0 && m == "1";
22+
y = s == 0 && m(1) == '1';
2323

2424
end

+stdlib/+perl/samepath.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
try %#ok<TRYNC>
66
exe = stdlib.perl_exe();
7-
if stdlib.strempty(exe)
7+
if ismissing(exe)
88
return
99
end
1010

+stdlib/has_perl.m

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
function y = has_perl()
44

5-
y = ~isempty(stdlib.perl_version());
5+
v = stdlib.perl_version();
6+
y = ~isempty(v) && ~ismissing(v);
67

78
end
8-
9-
%!assert (islogical(stdlib.has_perl()))

+stdlib/perl_exe.m

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
ps = [fileparts(mfilename('fullpath')), '/private/executable.pl'];
1414

15-
exe = '';
15+
exe = missing;
1616

1717
try
1818
[r, s] = perl(ps);
@@ -29,5 +29,3 @@
2929
end
3030

3131
end
32-
33-
%!assert (isfile(stdlib.perl_exe()))

+stdlib/perl_version.m

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
return
1717
end
1818

19-
v = [];
19+
v = missing;
2020

2121
exe = stdlib.perl_exe();
2222

23-
if ~stdlib.strempty(exe)
23+
if ~ismissing(exe)
2424
cmd = sprintf('"%s" -e %s', exe, stdlib.perl.perl2cmd('print $^V'));
2525

2626
[s, r] = system(cmd);
@@ -35,5 +35,3 @@
3535
perlv_cached = true;
3636

3737
end
38-
39-
%!assert (~isempty(stdlib.perl_version()))

example/+perl/device.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
i = missing;
66

77
exe = stdlib.perl_exe();
8-
if stdlib.strempty(exe)
8+
if ismissing(exe)
99
return
1010
end
1111

example/+perl/inode.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
i = missing;
77

88
exe = stdlib.perl_exe();
9-
if stdlib.strempty(exe)
9+
if ismissing(exe)
1010
return
1111
end
1212

example/+perl/normalize.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
n = string.empty;
99

1010
exe = stdlib.perl_exe();
11-
if stdlib.strempty(exe)
11+
if ismissing(exe)
1212
return
1313
end
1414

test/TestPlatform.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ function test_toolbox_used(tc)
4747

4848
methods (Test, TestTags={'R2018a'})
4949
function test_perl(tc)
50-
tc.verifyNotEmpty(stdlib.perl_exe())
50+
tc.verifyClass(stdlib.perl_exe(), 'char')
51+
tc.verifyClass(stdlib.perl_version(), 'double')
5152
tc.verifyNotEmpty(stdlib.perl_version())
5253
tc.verifyTrue(stdlib.has_perl(), 'Matlab docs indicate that Perl should always be available')
5354
end

0 commit comments

Comments
 (0)