feat: handle balances when returned as null (when hub connected to getalby.com is offfline)#3312
Open
pavanjoshi914 wants to merge 1 commit into
Open
feat: handle balances when returned as null (when hub connected to getalby.com is offfline)#3312pavanjoshi914 wants to merge 1 commit into
pavanjoshi914 wants to merge 1 commit into
Conversation
…d to getalby.com is offline
Member
Author
|
NaN also belong to number object so we cannot use typeof x == "number" to exlude it. so i used Number.isFinite() for checks this helps hiding balances for all the cases where balance doesnt have actual balance returned |
pavanjoshi914
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after:
