fix: remove stray div tags from translations#3574
Open
joaothallis wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
✅ Files skipped from review due to trivial changes (15)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoves stray Changesi18n Translation Markup Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
joaothallis
marked this pull request as ready for review
June 29, 2026 00:46
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/locales/fa/translation.json`:
- Line 426: The CTA text in the fa translation for no_mnemonic_hint contains a
typo that renders awkwardly; update the string in the translation entry to use
the correct phrase “اینجا کلیک کنید” instead of “اینجا کلید کنید”. Keep the rest
of the localized message unchanged.
In `@src/i18n/locales/zh_Hans/translation.json`:
- Line 408: The localized CTA text contains an accidental extra Latin character
in the translation value for the mnemonic hint. Update the `no_mnemonic_hint`
string in the zh_Hans translation entry so the link text uses the intended
Chinese phrase only, removing the stray “e” from `点击此处e` while keeping the
surrounding markup unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fbf240f1-c7e2-46be-a139-a427308c0c15
📒 Files selected for processing (16)
src/i18n/locales/en/translation.jsonsrc/i18n/locales/fa/translation.jsonsrc/i18n/locales/fi/translation.jsonsrc/i18n/locales/id/translation.jsonsrc/i18n/locales/ja/translation.jsonsrc/i18n/locales/pl/translation.jsonsrc/i18n/locales/pt/translation.jsonsrc/i18n/locales/pt_BR/translation.jsonsrc/i18n/locales/ru/translation.jsonsrc/i18n/locales/si/translation.jsonsrc/i18n/locales/sv/translation.jsonsrc/i18n/locales/ta/translation.jsonsrc/i18n/locales/th/translation.jsonsrc/i18n/locales/uk/translation.jsonsrc/i18n/locales/zh_Hans/translation.jsonsrc/i18n/locales/zh_Hant/translation.json
joaothallis
force-pushed
the
fix/master-key-translation-div
branch
from
June 29, 2026 20:18
d1b661c to
656fa1e
Compare
joaothallis
force-pushed
the
fix/master-key-translation-div
branch
from
June 29, 2026 20:20
656fa1e to
eb7720d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Remove stray
</div>fragments from the Master Key hint translation strings so the<Trans>content renders correctly in the Accounts and Nostr settings views.Type of change
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
Before:
After:
Checklist
Summary by CodeRabbit
</div>fragments that were appearing in the displayed text in the Nostr/mnemonic setup and recovery flows.