Skip to content

Commit 7c9f976

Browse files
committed
check public API's can be replaced
1 parent 2c7e364 commit 7c9f976

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

datafusion/datasource-avro/src/file_format.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// under the License.
1717

1818
//! Apache Avro [`FileFormat`] abstractions
19-
19+
// todo - Check if it can be replaced with arrow-avro
2020
use std::any::Any;
2121
use std::collections::HashMap;
2222
use std::fmt;

datafusion/datasource-avro/src/source.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,9 @@ impl AvroSource {
5656
self.schema.expect("Schema must set before open").as_ref(),
5757
)?;
5858
ReaderBuilder::new()
59-
.with_reader_schema(avro_schema)
59+
.with_reader_schema(avro_schema) // Used for projection on read.
6060
.with_batch_size(self.batch_size.expect("Batch size must set before open"))
61-
.build(reader)
61+
.build(reader) // TODO - A File (which doesn't implement BufRead) is being passed; confirm whether this is safe.
6262
.map_err(Into::into)
6363
}
6464
}

0 commit comments

Comments
 (0)