Add unit test for keychain handler, network handler, mobile provision, user defaults

Author: vineetchoudhary

AppBox.xcodeproj/project.pbxproj

@@ -7,16 +7,13 @@
 	objects = {
 
 /* Begin PBXBuildFile section */
-		0D4C02332FC22A63EFF72F8D /* NSStringTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 30509E5843B9CCEA2AFB2874 /* NSStringTests.m */; };
-		407C8032774422D6217359B9 /* NSExceptionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B386EED60B876CEE11BBF89B /* NSExceptionTests.m */; };
 		4410D18E26FF76A20046E5F9 /* DBAccountManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 4410D18D26FF76A20046E5F9 /* DBAccountManager.m */; };
 		4410D19C26FF851D0046E5F9 /* CoreDataMigration3to4.xcmappingmodel in Sources */ = {isa = PBXBuildFile; fileRef = 4410D19B26FF851D0046E5F9 /* CoreDataMigration3to4.xcmappingmodel */; };
 		449BD6B8282111B0008EFB2B /* AppBoxService+CoreDataProperties.m in Sources */ = {isa = PBXBuildFile; fileRef = 449BD6B4282111B0008EFB2B /* AppBoxService+CoreDataProperties.m */; };
 		449BD6B9282111B0008EFB2B /* AppBoxService+CoreDataClass.m in Sources */ = {isa = PBXBuildFile; fileRef = 449BD6B5282111B0008EFB2B /* AppBoxService+CoreDataClass.m */; };
 		4D3E492303A5E78B0417E17F /* ObjectiveDropboxOfficial.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 656E98171CB7E85AA663AFE8 /* ObjectiveDropboxOfficial.xcframework */; };
 		5D20E6B57EA90CA7D6EA21F7 /* IPAUploadInfoTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 3E65C0AF09D32F39F4259167 /* IPAUploadInfoTests.m */; };
 		6968AADC9DEB5554A06F19BD /* CocoaLumberjack in Frameworks */ = {isa = PBXBuildFile; productRef = 33146DD70AA7C380685E53AA /* CocoaLumberjack */; };
-		7288A761B4712E54C04CE3CA /* NSURLTests.m in Sources */ = {isa = PBXBuildFile; fileRef = BA16F2A781DF1BAB101AACAE /* NSURLTests.m */; };
 		771E1F8D4D831C50C1178A75 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 09E11F809EFA1C7844F25D6B /* Cocoa.framework */; };
 		AC4CF046F7F2B76CF56BF8E4 /* ObjectiveDropboxOfficial.xcframework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 656E98171CB7E85AA663AFE8 /* ObjectiveDropboxOfficial.xcframework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
 		D9E5B24A6827FC5AD68D29D0 /* CommonTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 544B2D28AEC66102492FA05E /* CommonTests.m */; };
@@ -97,8 +94,11 @@
 		E1D12EEC1EC31AC80065E59A /* AccountPreferencesViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = E1D12EEB1EC31AC80065E59A /* AccountPreferencesViewController.xib */; };
 		E1D12EEE1EC320760065E59A /* HelpPreferencesViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = E1D12EED1EC320760065E59A /* HelpPreferencesViewController.xib */; };
 		E1DC26001ECDBCA8001EF106 /* MBProgressHUD+ProgressHud.m in Sources */ = {isa = PBXBuildFile; fileRef = E1DC25FF1ECDBCA8001EF106 /* MBProgressHUD+ProgressHud.m */; };
-		E6BF0C7BDA3380B61FA14F6C /* NSDateTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 7E5177E6B8643457D0035658 /* NSDateTests.m */; };
 		F6AEC01BE879A2BB998E829D /* ZipArchive in Frameworks */ = {isa = PBXBuildFile; productRef = EFE5EA7464F3539F2562A787 /* ZipArchive */; };
+		AA11BB22CC33DD44EE550011 /* NetworkHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = AA11BB22CC33DD44EE550001 /* NetworkHandlerTests.m */; };
+		AA11BB22CC33DD44EE550012 /* MobileProvisionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = AA11BB22CC33DD44EE550002 /* MobileProvisionTests.m */; };
+		AA11BB22CC33DD44EE550013 /* KeychainHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = AA11BB22CC33DD44EE550003 /* KeychainHandlerTests.m */; };
+		AA11BB22CC33DD44EE550014 /* UserDataTests.m in Sources */ = {isa = PBXBuildFile; fileRef = AA11BB22CC33DD44EE550004 /* UserDataTests.m */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -147,8 +147,7 @@
 
 /* Begin PBXFileReference section */
 		09E11F809EFA1C7844F25D6B /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/System/Library/Frameworks/Cocoa.framework; sourceTree = DEVELOPER_DIR; };
-		30509E5843B9CCEA2AFB2874 /* NSStringTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = NSStringTests.m; sourceTree = "<group>"; };
-		3E65C0AF09D32F39F4259167 /* IPAUploadInfoTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = IPAUploadInfoTests.m; sourceTree = "<group>"; };
+		3E65C0AF09D32F39F4259167 /* IPAUploadInfoTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = IPAUploadInfoTests.m; path = Model/IPAUploadInfoTests.m; sourceTree = "<group>"; };
 		4410D18C26FF76A20046E5F9 /* DBAccountManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DBAccountManager.h; sourceTree = "<group>"; };
 		4410D18D26FF76A20046E5F9 /* DBAccountManager.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = DBAccountManager.m; sourceTree = "<group>"; };
 		4410D19B26FF851D0046E5F9 /* CoreDataMigration3to4.xcmappingmodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcmappingmodel; path = CoreDataMigration3to4.xcmappingmodel; sourceTree = "<group>"; };
@@ -157,11 +156,8 @@
 		449BD6B6282111B0008EFB2B /* AppBoxService+CoreDataProperties.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "AppBoxService+CoreDataProperties.h"; sourceTree = "<group>"; };
 		449BD6B7282111B0008EFB2B /* AppBoxService+CoreDataClass.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "AppBoxService+CoreDataClass.h"; sourceTree = "<group>"; };
 		44DCC66B25EEA1910074AB1E /* AppBox4.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = AppBox4.xcdatamodel; sourceTree = "<group>"; };
-		544B2D28AEC66102492FA05E /* CommonTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = CommonTests.m; sourceTree = "<group>"; };
+		544B2D28AEC66102492FA05E /* CommonTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = CommonTests.m; path = Common/CommonTests.m; sourceTree = "<group>"; };
 		656E98171CB7E85AA663AFE8 /* ObjectiveDropboxOfficial.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = ObjectiveDropboxOfficial.xcframework; path = Frameworks/ObjectiveDropboxOfficial.xcframework; sourceTree = "<group>"; };
-		7E5177E6B8643457D0035658 /* NSDateTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = NSDateTests.m; sourceTree = "<group>"; };
-		B386EED60B876CEE11BBF89B /* NSExceptionTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = NSExceptionTests.m; sourceTree = "<group>"; };
-		BA16F2A781DF1BAB101AACAE /* NSURLTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; path = NSURLTests.m; sourceTree = "<group>"; };
 		DB0435832E696255005F0173 /* appboxcli */ = {isa = PBXFileReference; explicitFileType = "compiled.mach-o.executable"; includeInIndex = 0; path = appboxcli; sourceTree = BUILT_PRODUCTS_DIR; };
 		DB04358F2E6962EA005F0173 /* CLISupportHelper.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CLISupportHelper.h; sourceTree = "<group>"; };
 		DB0435902E6962EA005F0173 /* CLISupportHelper.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CLISupportHelper.m; sourceTree = "<group>"; };
@@ -300,6 +296,10 @@
 		E1DC25FE1ECDBCA8001EF106 /* MBProgressHUD+ProgressHud.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "MBProgressHUD+ProgressHud.h"; sourceTree = "<group>"; };
 		E1DC25FF1ECDBCA8001EF106 /* MBProgressHUD+ProgressHud.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "MBProgressHUD+ProgressHud.m"; sourceTree = "<group>"; };
 		E1FECA821E83EE5000C4E9AE /* HTTPStatusCode.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = HTTPStatusCode.h; sourceTree = "<group>"; };
+		AA11BB22CC33DD44EE550001 /* NetworkHandlerTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = NetworkHandlerTests.m; path = Common/NetworkHandler/NetworkHandlerTests.m; sourceTree = "<group>"; };
+		AA11BB22CC33DD44EE550002 /* MobileProvisionTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = MobileProvisionTests.m; path = Common/MobileProvision/MobileProvisionTests.m; sourceTree = "<group>"; };
+		AA11BB22CC33DD44EE550003 /* KeychainHandlerTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = KeychainHandlerTests.m; path = Common/KeychainHandler/KeychainHandlerTests.m; sourceTree = "<group>"; };
+		AA11BB22CC33DD44EE550004 /* UserDataTests.m */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.c.objc; name = UserDataTests.m; path = Common/UserManager/UserDataTests.m; sourceTree = "<group>"; };
 /* End PBXFileReference section */
 
 /* Begin PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet section */
@@ -369,16 +369,64 @@
 			name = "OS X";
 			sourceTree = "<group>";
 		};
+		AA11BB22CC33DD44EE550022 /* NetworkHandler */ = {
+			isa = PBXGroup;
+			children = (
+				AA11BB22CC33DD44EE550001 /* NetworkHandlerTests.m */,
+			);
+			name = NetworkHandler;
+			sourceTree = "<group>";
+		};
+		AA11BB22CC33DD44EE550023 /* MobileProvision */ = {
+			isa = PBXGroup;
+			children = (
+				AA11BB22CC33DD44EE550002 /* MobileProvisionTests.m */,
+			);
+			name = MobileProvision;
+			sourceTree = "<group>";
+		};
+		AA11BB22CC33DD44EE550024 /* KeychainHandler */ = {
+			isa = PBXGroup;
+			children = (
+				AA11BB22CC33DD44EE550003 /* KeychainHandlerTests.m */,
+			);
+			name = KeychainHandler;
+			sourceTree = "<group>";
+		};
+		AA11BB22CC33DD44EE550025 /* UserManager */ = {
+			isa = PBXGroup;
+			children = (
+				AA11BB22CC33DD44EE550004 /* UserDataTests.m */,
+			);
+			name = UserManager;
+			sourceTree = "<group>";
+		};
+		AA11BB22CC33DD44EE550021 /* Common */ = {
+			isa = PBXGroup;
+			children = (
+				544B2D28AEC66102492FA05E /* CommonTests.m */,
+				AA11BB22CC33DD44EE550022 /* NetworkHandler */,
+				AA11BB22CC33DD44EE550023 /* MobileProvision */,
+				AA11BB22CC33DD44EE550024 /* KeychainHandler */,
+				AA11BB22CC33DD44EE550025 /* UserManager */,
+			);
+			name = Common;
+			sourceTree = "<group>";
+		};
+		AA11BB22CC33DD44EE550026 /* Model */ = {
+			isa = PBXGroup;
+			children = (
+				3E65C0AF09D32F39F4259167 /* IPAUploadInfoTests.m */,
+			);
+			name = Model;
+			sourceTree = "<group>";
+		};
 		AECBA8D5D0C166DA17FF6ED0 /* AppBoxTests */ = {
 			isa = PBXGroup;
 			children = (
 				DB5BA12A2FC9C94E00A150BA /* AppBoxTests.xctestplan */,
-				3E65C0AF09D32F39F4259167 /* IPAUploadInfoTests.m */,
-				30509E5843B9CCEA2AFB2874 /* NSStringTests.m */,
-				BA16F2A781DF1BAB101AACAE /* NSURLTests.m */,
-				7E5177E6B8643457D0035658 /* NSDateTests.m */,
-				B386EED60B876CEE11BBF89B /* NSExceptionTests.m */,
-				544B2D28AEC66102492FA05E /* CommonTests.m */,
+				AA11BB22CC33DD44EE550021 /* Common */,
+				AA11BB22CC33DD44EE550026 /* Model */,
 			);
 			path = AppBoxTests;
 			sourceTree = "<group>";
@@ -1090,11 +1138,11 @@
 			buildActionMask = 2147483647;
 			files = (
 				5D20E6B57EA90CA7D6EA21F7 /* IPAUploadInfoTests.m in Sources */,
-				0D4C02332FC22A63EFF72F8D /* NSStringTests.m in Sources */,
-				7288A761B4712E54C04CE3CA /* NSURLTests.m in Sources */,
-				E6BF0C7BDA3380B61FA14F6C /* NSDateTests.m in Sources */,
-				407C8032774422D6217359B9 /* NSExceptionTests.m in Sources */,
 				D9E5B24A6827FC5AD68D29D0 /* CommonTests.m in Sources */,
+				AA11BB22CC33DD44EE550011 /* NetworkHandlerTests.m in Sources */,
+				AA11BB22CC33DD44EE550012 /* MobileProvisionTests.m in Sources */,
+				AA11BB22CC33DD44EE550013 /* KeychainHandlerTests.m in Sources */,
+				AA11BB22CC33DD44EE550014 /* UserDataTests.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

AppBoxTests/AppBoxTests.xctestplan

@@ -9,7 +9,8 @@
     }
   ],
   "defaultOptions" : {
-    "performanceAntipatternCheckerEnabled" : true
+    "performanceAntipatternCheckerEnabled" : true,
+    "uiTestingScreenshotsLifetime" : "keepNever"
   },
   "testTargets" : [
     {

AppBoxTests/CommonTests.m AppBoxTests/Common/CommonTests.mAppBoxTests/CommonTests.m renamed to AppBoxTests/Common/CommonTests.m

@@ -0,0 +1,68 @@
+//
+//  KeychainHandlerTests.m
+//  AppBoxTests
+//
+//  Created by AppBox on 29/05/26.
+//  Copyright © 2026 Developer Insider. All rights reserved.
+//
+
+#import <XCTest/XCTest.h>
+#import "KeychainHandler.h"
+
+@interface KeychainHandlerTests : XCTestCase
+@end
+
+@implementation KeychainHandlerTests
+
+#pragma mark - errorMessageForStatus Tests
+
+- (void)testErrorMessageForStatus_Success_ReturnsNoError {
+    NSString *message = [KeychainHandler errorMessageForStatus:errSecSuccess];
+    XCTAssertNotNil(message);
+    // errSecSuccess (0) should not produce an error-style message
+    XCTAssertGreaterThan(message.length, 0);
+}
+
+- (void)testErrorMessageForStatus_ItemNotFound_ReturnsMessage {
+    NSString *message = [KeychainHandler errorMessageForStatus:errSecItemNotFound];
+    XCTAssertNotNil(message);
+    XCTAssertGreaterThan(message.length, 0);
+}
+
+- (void)testErrorMessageForStatus_AuthFailed_ReturnsMessage {
+    NSString *message = [KeychainHandler errorMessageForStatus:errSecAuthFailed];
+    XCTAssertNotNil(message);
+    XCTAssertGreaterThan(message.length, 0);
+}
+
+- (void)testErrorMessageForStatus_DuplicateItem_ReturnsMessage {
+    NSString *message = [KeychainHandler errorMessageForStatus:errSecDuplicateItem];
+    XCTAssertNotNil(message);
+    XCTAssertGreaterThan(message.length, 0);
+}
+
+- (void)testErrorMessageForStatus_DifferentStatusesDifferentMessages {
+    NSString *notFound = [KeychainHandler errorMessageForStatus:errSecItemNotFound];
+    NSString *duplicate = [KeychainHandler errorMessageForStatus:errSecDuplicateItem];
+    XCTAssertNotEqualObjects(notFound, duplicate);
+}
+
+#pragma mark - Constants Tests
+
+- (void)testKeychainAccountKey_HasExpectedValue {
+    XCTAssertEqualObjects(kSAMKeychainAccountKey, @"acct");
+}
+
+- (void)testKeychainLabelKey_HasExpectedValue {
+    XCTAssertEqualObjects(kSAMKeychainLabelKey, @"labl");
+}
+
+#pragma mark - accountsForService Tests
+
+- (void)testAccountsForService_WithNonExistentService_ReturnsEmptyArray {
+    NSArray *accounts = [KeychainHandler accountsForService:@"com.appbox.test.nonexistent.service.12345"];
+    XCTAssertNotNil(accounts);
+    XCTAssertEqual(accounts.count, 0);
+}
+
+@end