Restart CLI processes when environment or telemetry settings change#954
Open
dividedmind wants to merge 2 commits into
Open
Restart CLI processes when environment or telemetry settings change#954dividedmind wants to merge 2 commits into
dividedmind wants to merge 2 commits into
Conversation
The JSON-RPC server was already restarted when telemetry settings or the CLI environment changed (e.g. via organization config refresh), but the indexer and scanner processes receive the same environment (AppLandCliEnvProvider extensions, including Splunk telemetry env vars) and were left running with stale values until a manual restart or project reload. Add a second debounced restart, mirroring the existing JSON-RPC alarm, that calls AppLandCommandLineService.restartProcessesInBackground() alongside the RPC restart for both triggers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018yFMfB9M3n6bSzWFJjvTQA
There was a problem hiding this comment.
Pull request overview
This PR updates the settings-change handling in the IntelliJ plugin so that AppLand’s long-running CLI processes (indexer/scanner) are restarted when settings that affect their environment (CLI env vars and telemetry configuration) change, keeping them aligned with the JSON-RPC server behavior.
Changes:
- Added a lazily initialized
reloadCliProcessesAlarmto debounce CLI process restarts. - Updated
cliEnvironmentChanged()to restart CLI processes in addition to restarting the JSON-RPC server. - Updated
telemetrySettingsChanged()to restart CLI processes alongside the JSON-RPC server, and clarified comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dividedmind
force-pushed
the
claude/splunk-locked-network-analysis-rhi250
branch
from
July 18, 2026 11:23
b6ad5d4 to
2e2a290
Compare
Prevent the GitHub Actions AppMap test binaries cache from growing unboundedly, and completely eliminate redundant cache save churn (zipping and network uploads) on steady-state runs. - Transition from `actions/cache@v5` to explicit, decoupled `actions/cache/restore@v5` and `actions/cache/save@v5` steps. - Add `id: restore-cache` to track the matched key retrieved from GitHub. - Create `.github/workflows/clean-cache.js` to parse version numbers of surviving binaries, prune old releases, delete test stub files, and export a SHA-256 hash of the final stable binaries set to `$GITHUB_OUTPUT`. - Configure the `Save AppMap test binaries cache` step to compare the new hash-based key against the matched/restored key. If they match, the step is completely skipped, saving network bandwidth and runner CPU. - Configure steps with `continue-on-error: true` to defensively guard the build from any unexpected script/cache failures. - Add descriptive comments in the workflow explaining the decoupled restore/save setup, the pruning logic, and the matched-key conditional optimization.
dividedmind
force-pushed
the
claude/splunk-locked-network-analysis-rhi250
branch
from
July 18, 2026 12:03
2e2a290 to
939fb50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that AppLand's CLI processes (indexer and scanner) are properly restarted when environment variables or telemetry settings are modified, keeping them in sync with the JSON-RPC server.
Key Changes
reloadCliProcessesAlarmlazy-initialized alarm to handle CLI process restartsAppLandCommandLineServiceto enable CLI process managementcliEnvironmentChanged()to restart CLI processes alongside the JSON-RPC server when environment variables are modifiedtelemetrySettingsChanged()to restart CLI processes alongside the JSON-RPC server when telemetry settings are modifiedImplementation Details
cliEnvironmentChanged()andtelemetrySettingsChanged()now trigger CLI process restarts to ensure configuration changes take effect across all AppLand servicesBonus changes