refactor: Pick copilot model#1055
Open
dustinbyrne wants to merge 1 commit into
Open
Conversation
dustinbyrne
force-pushed
the
refactor/copilot-model
branch
from
4a8795f to
3f88149
Compare
dividedmind
approved these changes
Nov 25, 2024
dividedmind
left a comment
dividedmind
left a comment
Contributor
There was a problem hiding this comment.
Looks ok, thanks! One thing that's bugging me: won't calling refreshModels() here https://github.com/getappmap/vscode-appland/pull/1055/files#diff-7f9409f608e34972dc33bd02b1bb6d84fb8d0b412cbd6d3d4d01d054a1da9fb6R18 potentially cause it to miss a change in the auto-chosen model (in case the list changed in the meantime and refreshModels() wasn't called before for some reason, eg. due to a race)? I suppose it's unlikely to ever happen, but maybe it's more correct not to call it there at all (and make it private for good measure, although that might complicate tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the requested changes in #1053