Skip to content

Open exported sequence diagram svg in browser #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahtrotta wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Open exported sequence diagram svg in browser #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/editor/appmapEditorProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ import { getStackLocations, StackLocation } from '../lib/getStackLocations';
import { ResolvedFinding } from '../services/resolvedFinding';
import getWebviewContent from '../webviews/getWebviewContent';
import ErrorCode from '../telemetry/definitions/errorCodes';
import { promisify } from 'util';
import { tmpName } from 'tmp';
import { writeFile } from 'fs/promises';

export type FindingInfo = ResolvedFinding & {
stackLocations?: StackLocation[];
Expand Down Expand Up @@ -224,15 +227,10 @@ export default class AppMapEditorProvider
try {
const { svgString } = message;
if (svgString) {
const comment =
'\n<!-- Save this SVG file with a .svg file extension ' +
'and then open it in a web browswer to view your appmap! -->\n\n';
const document = await vscode.workspace.openTextDocument({
language: 'svg',
content: comment + svgString,
});

vscode.window.showTextDocument(document);
const diagramFile = (await promisify(tmpName)()) + '.svg';
await writeFile(diagramFile, svgString);
const uri = vscode.Uri.file(diagramFile);
vscode.env.openExternal(uri);
Telemetry.sendEvent(EXPORT_SVG);
}
} catch (e) {
Expand Down