Skip to content

Commit 2771186

Browse files
fix(test): use proper Finding objects instead of strings in MASFEATTypesTest
1 parent fba24fc commit 2771186

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

src/test/java/com/getaxonflow/sdk/masfeat/MASFEATTypesTest.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,15 @@ void testSettersAndGetters() {
414414
assessment.setAccountabilityScore(88);
415415
assessment.setTransparencyScore(92);
416416
assessment.setOverallScore(89);
417-
assessment.setFindings(List.of("Finding 1"));
417+
Finding finding = Finding.builder()
418+
.id("f-1")
419+
.pillar(FEATPillar.FAIRNESS)
420+
.severity(FindingSeverity.MINOR)
421+
.category("test-category")
422+
.description("Finding 1")
423+
.status(FindingStatus.OPEN)
424+
.build();
425+
assessment.setFindings(List.of(finding));
418426
assessment.setRecommendations(List.of("Recommendation 1"));
419427
assessment.setAssessors(List.of("assessor1"));
420428
assessment.setApprovedBy("approver@example.com");
@@ -433,7 +441,8 @@ void testSettersAndGetters() {
433441
assertThat(assessment.getAccountabilityScore()).isEqualTo(88);
434442
assertThat(assessment.getTransparencyScore()).isEqualTo(92);
435443
assertThat(assessment.getOverallScore()).isEqualTo(89);
436-
assertThat(assessment.getFindings()).containsExactly("Finding 1");
444+
assertThat(assessment.getFindings()).hasSize(1);
445+
assertThat(assessment.getFindings().get(0).getDescription()).isEqualTo("Finding 1");
437446
assertThat(assessment.getRecommendations()).containsExactly("Recommendation 1");
438447
assertThat(assessment.getAssessors()).containsExactly("assessor1");
439448
assertThat(assessment.getApprovedBy()).isEqualTo("approver@example.com");

0 commit comments

Comments
 (0)