Commit 5007004
committed
fold(hitl): R3 round 1 — dedupe setUp endpoint() + narrow exception class
R3 round 1 surfaced two folds against the Java HITL PR:
- MED-1: HITLTest.setUp called .endpoint(wmRuntimeInfo.getHttpBaseUrl())
twice on the same builder (copy-paste bug, harmless at runtime but a
real code-smell). Collapsed to a single chained call.
- MED-5: All three platform-error tests (400 bad-notify_url-scheme, 401
auth, network failure via CONNECTION_RESET_BY_PEER) asserted
.isInstanceOf(Exception.class) which would pass even on
NullPointerException. Narrowed to AxonFlowException.class to match
the @throws AxonFlowException javadoc at AxonFlow.java:6440 and the
required-field guard tests at lines 387/397/407 which already narrow
to IllegalArgumentException.
Tests still green: 25/25 in HITLTest (8 under CreateHITLRequest).
Refs getaxonflow/axonflow-enterprise#2421
Signed-off-by: Saurabh Jain <saurabh.jain@getaxonflow.com>1 parent 00bddf1 commit 5007004
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
| 81 | + | |
85 | 82 | | |
86 | 83 | | |
87 | 84 | | |
| |||
334 | 331 | | |
335 | 332 | | |
336 | 333 | | |
337 | | - | |
| 334 | + | |
| 335 | + | |
338 | 336 | | |
339 | 337 | | |
340 | 338 | | |
| |||
355 | 353 | | |
356 | 354 | | |
357 | 355 | | |
358 | | - | |
| 356 | + | |
| 357 | + | |
359 | 358 | | |
360 | 359 | | |
361 | 360 | | |
| |||
376 | 375 | | |
377 | 376 | | |
378 | 377 | | |
379 | | - | |
| 378 | + | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| |||
0 commit comments