fix: telemetry fixes, auditToolCall method#111
Merged
Conversation
…on in telemetry - Read SDK_VERSION from Maven pom.properties at runtime instead of hardcoded constant to prevent version drift between pom.xml and telemetry payload - Detect platform version by calling /health endpoint before sending telemetry ping (2s timeout, silent failure)
Map 'Mac OS X' -> 'darwin', 'aarch64' -> 'arm64' for consistency across SDKs.
Avoids manual drift risk when the version bumps but the fallback string is forgotten. pom.properties and manifest should always resolve in packaged JARs.
…e try-with-resources - Skip version compatibility warning when SDK_VERSION is "unknown" (prevents spurious warnings when running from source/IDE) - Add amd64 -> x64 mapping in normalizeArch for Linux consistency - Use try-with-resources for InputStream in detectSdkVersion
When the SDK endpoint is localhost, 127.0.0.1, or [::1], telemetry pings are now suppressed unless telemetryEnabled is explicitly set to true. Prevents telemetry leaks during local development. Updated 4 tests to pass telemetryEnabled=true for WireMock localhost endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"4.0.0"fallback with"unknown", guardcompareSemveragainst unknown version, addamd64tox64arch normalization, use try-with-resources for InputStreamauditToolCall()andauditToolCallAsync()methods withAuditToolCallRequest/AuditToolCallResponsetypesTest plan
mvn testpasses (1030 tests)AuditToolCallRequest.builder().toolName("x").build()