feat(client): add listLLMProviders() — closes provider-listing parity gap#145
Merged
Conversation
4 tasks
saurabhjain1592
added a commit
that referenced
this pull request
Apr 28, 2026
…nation, encoding (#148) * fix(client): close review gaps on listLLMProviders — full shape, pagination, encoding Six review-driven fixes on the just-shipped listLLMProviders (PR #145): 1. Wire-shape: LLMProvider was silently dropping endpoint, model, region, rate_limit, timeout_seconds, and settings — every provider config the SDK couldn't introspect. Surfaced all six fields. enabled/priority/ weight/hasApiKey are now boxed (Boolean/Integer) so a missing JSON value is distinguishable from explicit false/0. 2. Pagination: GET /api/v1/llm-providers is paginated (server cap 100, default 20). The 2-arg listLLMProviders ignored that and would silently truncate results in any deployment with >20 providers. Added: - listLLMProviders(type, enabled, page, pageSize) — single page - listLLMProvidersPaged(...) — single page + LLMProviderListResponse (with PaginationMeta) - listAllLLMProviders(type, enabled[, pageSize]) — walks every page 3. URL encoding: query string is now built with HttpUrl.Builder instead of manual StringBuilder concat. Reserved chars in `type` filter (e.g. "&") are now properly URL-encoded. 4. Duplicate @JsonProperty: removed the redundant annotation on LLMProviderHealth.getLastChecked() — the constructor parameter annotation is sufficient. 5. Boxed booleans: LLMProvider.getEnabled() / getHasApiKey() return Boolean (nullable) so callers can distinguish "explicitly false" from "field omitted by older platform". Convenience isEnabled() / hasApiKey() return primitive boolean (false on null). 6. New types: LLMProviderListResponse, PaginationMeta in types/ package. 7 new regression tests in AxonFlowTest cover: full-shape round-trip, pagination metadata, multi-page walk, combined filters (type+enabled), URL encoding for reserved chars, null health field, omitted-enabled boxed-Boolean behaviour. 163 total tests pass. * chore(wire-shape): refresh baseline for new LLMProvider/PaginationMeta fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `listLLMProviders()` to the Java SDK (with optional `type` and `enabled` filters and an async variant), closing the parity gap with the Python SDK's `list_providers()`, the Go SDK's `ListProviders()`, and the TypeScript SDK's `listProviders()`. Caught by the Phase 1 quality-freeze sweep.
What changed
Test plan