hack-cleanup: AxonFlowException catch + Maven mirror composite action#152
Merged
Conversation
Hack-audit pass on the QF-14 Java workstream. Two leftover shortcuts flagged in the deep review: 1. examples/basic Basic.java caught `RuntimeException` for the community-fail-open path. The SDK exception hierarchy is rooted at `AxonFlowException extends RuntimeException`, so catching `RuntimeException` was overly broad — would have swallowed any non-SDK runtime error (NullPointerException from a SDK regression, IllegalStateException from a misuse, etc.) and printed it as "non-success". Tightened to `AxonFlowException`. The smoke now propagates non-SDK runtime errors to the JVM default handler, which exits non-zero and surfaces the stack trace. 2. The Maven mirror config block (~13 lines) was duplicated 5 times across ci.yml + integration.yml. Extracted to a composite action `.github/actions/setup-maven`. All 5 sites now reference `uses: ./.github/actions/setup-maven`. ~65 lines of YAML duplication removed; if the mirror URL ever rotates, one change instead of five. Verified: mvn install (parent + example) clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honest hack-cleanup PR. When the user asked "did you make any hacks/shortcuts during the QF-14 review work?", two leftover items from the deep review:
Basic.javacaughtRuntimeExceptionfor the community-fail-open path (the catch block in review fixes: integration.yml, basic example, surefire binding #149's review-fixes was tighter than the originalException, but still over-broad). The SDK exception hierarchy is rooted atAxonFlowException extends RuntimeException— catchingRuntimeExceptionwould have swallowed any non-SDK runtime error (NullPointerException from a SDK regression, IllegalStateException from a misuse, etc.) and printed it as "non-success". Tightened toAxonFlowException.Maven mirror config duplicated 5 times across
ci.yml(3 jobs) +integration.yml(2 jobs). Reviewer flagged it as P2 polish. Extracted to a composite action.github/actions/setup-maven. ~65 lines of YAML duplication removed; if the mirror URL ever rotates, one change instead of five.Test plan
mvn install -DskipTests -Bclean (parent + example)cd examples/basic && mvn -B compilecleanWhat I'm not changing
wcp-retry-idempotencyexample pin to SDK 5.5.0 — known stale perfeedback_stale_replace_paths_in_examples.md. Bulk-bump sweeps deliberately skip these. The example still builds against 5.5.0 and the live-integration job only runsexamples/basic, not this one.proxyLLMCallexit semantics on community-without-LLM. Tightening further requires capability detection from/health(which the agent already publishes), tracked in examples: add minimal planning + connectors example dirs #146.