Fix TypeScript errors in test files caught by tsc during Docker build

Add tsc --noEmit typecheck step to pre-commit hook so type errors in
test files are caught locally before CI, matching what the Dockerfile
build does.

Author: jumpbetweenrows

.githooks/pre-commit

@@ -7,5 +7,8 @@ cargo fmt --check
 echo "→ cargo clippy -p proxy"
 cargo clippy -p proxy -- -D warnings
 
+echo "→ admin-ui typecheck"
+(cd admin-ui && npm run typecheck)
+
 echo "→ admin-ui tests"
 (cd admin-ui && npm run test:run)

admin-ui/package.json

@@ -8,7 +8,8 @@
     "build": "tsc -b && vite build",
     "preview": "vite preview",
     "test": "vitest",
-    "test:run": "vitest run"
+    "test:run": "vitest run",
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "@microsoft/fetch-event-source": "^2.0.1",

admin-ui/src/api/catalog.test.ts

@@ -18,7 +18,7 @@ import { client } from './client'
 import { fetchEventSource } from '@microsoft/fetch-event-source'
 import { submitAndStream, cancelDiscovery, getDiscoveryStatus, getCatalog } from './catalog'
 
-const mockClient = client as {
+const mockClient = client as unknown as {
   post: ReturnType<typeof vi.fn>
   get: ReturnType<typeof vi.fn>
   delete: ReturnType<typeof vi.fn>

admin-ui/src/api/client.test.ts

@@ -13,7 +13,7 @@ describe('api/client – request interceptor', () => {
   it('attaches Bearer token when localStorage has one', async () => {
     localStorage.setItem('token', 'my-jwt')
     // Re-import to run the module with the token already set
-    const { client } = await import('./client')
+    await import('./client')
     // Inspect the interceptor by checking what an outgoing request config looks like
     // via axios adapter mock
     const mockAdapter = vi.fn().mockResolvedValue({ data: {}, status: 200, headers: {}, config: {} })
@@ -24,7 +24,7 @@ describe('api/client – request interceptor', () => {
     testClient.interceptors.request.use((config) => {
       const token = localStorage.getItem('token')
       if (token) config.headers.Authorization = `Bearer ${token}`
-      capturedConfig = config as Record<string, unknown>
+      capturedConfig = config as unknown as Record<string, unknown>
       return config
     })
     testClient.defaults.adapter = mockAdapter
@@ -34,13 +34,13 @@ describe('api/client – request interceptor', () => {
 
   it('omits Authorization header when no token', async () => {
     // No token in localStorage
-    let capturedConfig: { headers: Record<string, unknown> } | null = null
+    let capturedConfig: { headers: { Authorization?: string } } | null = null
     const testClient = axios.create({ baseURL: '/api/v1' })
     const mockAdapter = vi.fn().mockResolvedValue({ data: {}, status: 200, headers: {}, config: {} })
     testClient.interceptors.request.use((config) => {
       const token = localStorage.getItem('token')
       if (token) config.headers.Authorization = `Bearer ${token}`
-      capturedConfig = config as { headers: Record<string, unknown> }
+      capturedConfig = config as unknown as { headers: { Authorization?: string } }
       return config
     })
     testClient.defaults.adapter = mockAdapter

admin-ui/src/api/datasources.test.ts

@@ -23,7 +23,7 @@ import {
   setDataSourceUsers,
 } from './datasources'
 
-const mockClient = client as {
+const mockClient = client as unknown as {
   post: ReturnType<typeof vi.fn>
   get: ReturnType<typeof vi.fn>
   put: ReturnType<typeof vi.fn>

admin-ui/src/api/users.test.ts

@@ -14,7 +14,7 @@ vi.mock('./client', () => ({
 import { client } from './client'
 import { login, getMe, listUsers, getUser, createUser, updateUser, changePassword, deleteUser } from './users'
 
-const mockClient = client as {
+const mockClient = client as unknown as {
   post: ReturnType<typeof vi.fn>
   get: ReturnType<typeof vi.fn>
   put: ReturnType<typeof vi.fn>

admin-ui/src/auth/AuthContext.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest'
-import { render, renderHook, act } from '@testing-library/react'
+import { renderHook, act } from '@testing-library/react'
 import { AuthProvider, useAuth } from './AuthContext'
 import { makeUser } from '../test/factories'
 

admin-ui/src/components/UserForm.test.tsx

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi } from 'vitest'
-import { screen, fireEvent } from '@testing-library/react'
+import { screen } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import { renderWithProviders } from '../test/test-utils'
 import { UserForm } from './UserForm'