Skip to content

Commit f4e5b2b

Browse files
Fix: correct access_mode default to policy_required in factory and docs
1 parent 36598f7 commit f4e5b2b

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313
- `PolicyHook` replaces hardcoded `RLSHook`; supports `row_filter`, `column_mask`, and `column_access` obligation types
1414
- Template variables (`{user.tenant}`, `{user.username}`, `{user.id}`) with parse-then-substitute injection safety
1515
- Wildcard matching (`schema: "*"`, `table: "*"`) in obligation definitions
16-
- `access_mode` field on datasources: `"open"` (default) or `"policy_required"` (no policy = empty results)
16+
- `access_mode` field on datasources: `"policy_required"` (default) or `"open"` (no policy = full access)
1717
- Optimistic concurrency on policy updates via `version` field (409 Conflict on mismatch)
1818
- Immutable `policy_version` snapshots on every policy mutation for audit traceability
1919
- Deny policies short-circuit with error before plan execution

admin-ui/src/test/factories.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export function makeDataSource(overrides: Partial<DataSource> = {}): DataSource
7373
ds_type: 'postgres',
7474
config: { host: 'localhost', port: 5432, db: 'mydb', user: 'postgres' },
7575
is_active: true,
76-
access_mode: 'open',
76+
access_mode: 'policy_required',
7777
last_sync_at: null,
7878
last_sync_result: null,
7979
created_at: '2024-01-01T00:00:00Z',

permission_stories.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ The following stories are implemented in the current release via the policy syst
469469
**Key design decisions for P0:**
470470
- Policies assign directly to users or all users (`user_id = NULL`). No roles/groups.
471471
- `is_admin` grants management API access only — does NOT bypass data policies.
472-
- Datasource `access_mode`: `"open"` (default) or `"policy_required"`.
472+
- Datasource `access_mode`: `"policy_required"` (default) or `"open"`.
473473
- Version snapshots for audit: every policy mutation increments `version` and creates a `policy_version` snapshot.
474474
- Template variables (`{user.tenant}`, etc.) use parse-then-substitute — immune to injection.
475475

0 commit comments

Comments
 (0)