Skip to content

Add static code analysis and make to test.yml #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Killpit wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Add static code analysis and make to test.yml #4

Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b60546e
add slither and echidna for security scan
Killpit Jul 12, 2024
f110988
change to self-hosted for local testing
Killpit Jul 12, 2024
305a176
change slither
Killpit Jul 12, 2024
d368c74
ubuntu-latest
Killpit Jul 12, 2024
99b10b7
changing the structure
Killpit Jul 15, 2024
24895b4
testing again
Killpit Jul 15, 2024
d1edc63
followed docs at slither-action
Killpit Jul 15, 2024
78c01b5
add --root to test to see how forge test work with ci
Killpit Jul 15, 2024
7956787
add .sol test file to improve forge test
Killpit Jul 15, 2024
d3cf9ae
revert back to forge test -vvv
Killpit Jul 15, 2024
b09b02d
Merge branch 'getclave:main' into main
Killpit Jul 16, 2024
52c801e
change in .toml file to accompany ci
Killpit Jul 16, 2024
3632471
Merge branch 'main' of https://github.com/Killpit/zksync-storage-proofs
Killpit Jul 16, 2024
d207dab
try out targeted tests on repo
Killpit Jul 16, 2024
90d8d68
add env for foundry
Killpit Jul 16, 2024
e4c1f60
remove env
Killpit Jul 16, 2024
b5ce7f8
add fuzz testing to critical functions
Killpit Jul 19, 2024
28a8a54
add relative file paths for echidna
Killpit Jul 19, 2024
2130828
adjust echidna to convention
Killpit Jul 19, 2024
ea6a352
re-add "src" to test new changes
Killpit Jul 19, 2024
a6f32cd
remove echidna to see how it works
Killpit Jul 19, 2024
d1deae8
fix echidna scans
Killpit Jul 19, 2024
ce7cd34
add forge build --build-info
Killpit Jul 19, 2024
8cffcfb
remove ignore compile in crytic args
Killpit Jul 19, 2024
d0521a1
add --ignore-compile
Killpit Jul 20, 2024
39456ee
modify crytic-args for testing
Killpit Jul 20, 2024
5c88ad4
add clean build with build info
Killpit Jul 20, 2024
882a4cd
most recent tests
Killpit Jul 20, 2024
0700fc6
root cause analysis finding for echidna
Killpit Jul 20, 2024
5b457af
add test mode: assertion
Killpit Jul 20, 2024
acd2ab9
remove fuzzing step
Killpit Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ jobs:
name: Foundry project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Checkout repository
uses: actions/checkout@v4
with:
submodules: recursive

Expand All @@ -22,13 +23,18 @@ jobs:
with:
version: nightly

- name: Run Slither analysis on Solidity files
uses: crytic/slither-action@v0.4.0
with:
ignore-compile: true

- name: Run Forge build
run: |
forge --version
forge build --sizes
forge build --sizes
id: build

- name: Run Forge tests
run: |
forge test -vvv
id: test
forge test -vvv --root packages/zksync-storage-contracts
id: test