Skip to content

docs: fix discrepancies between docs and latest implementation#81

Merged
yosriady merged 2 commits into
mainfrom
docs/accuracy-audit-fixes
May 21, 2026
Merged

docs: fix discrepancies between docs and latest implementation#81
yosriady merged 2 commits into
mainfrom
docs/accuracy-audit-fixes

Conversation

@yosriady

@yosriady yosriady commented May 21, 2026

Copy link
Copy Markdown
Contributor

Audit of docs against ../formono (features, API, MCP, CLI, SDK, data, security, integrations) and fixes for inaccurate or missing content.

MCP

  • Document Scale/Enterprise plan requirement + 403 troubleshooting
  • Correct tool table to the real allow-list (drop wallet_profiles, top_custom_events; rename top_sources_metrics -> top_sources; add missing tools); group top_* tools together
  • lifecycle/retention/frequency are first-class tools, not SQL-only

API

  • Add Get Contract page (GET /v0/contracts/{chain}/{address}) + nav

Events / SDK

  • Fix version "1" -> "0"; add transaction reverted status
  • Restore flattened function args (function_args is emitted both nested and flattened) + explain the behavior
  • Move address/user_id to top level in connect/disconnect/chain/ signature/identify samples
  • Add paid-attribution click IDs; fix mobile network_* context fields
  • Remove non-existent signatureHash from web SDK example
  • Refresh stale SDK versions; reframe page-event example to a DeFi flow

Features

  • Reframe Funnels/Flows/Retention as chart types (not nav pages); rename "User Flow" chart -> "Flow"
  • "Ask AI" -> "Ask Formo" across features and guides
  • Audience Insights / Segments live on the Users page
  • Alerts: webhook/Slack only (no Telegram/Email); User alerts gated
  • Remove fabricated behavioral wallet labels; use real label categories
  • Holdings tab -> Apps/Tokens

Data / Chains / Security / Integrations

  • Remove unimplemented linear (multi-touch) attribution
  • Catalog: real columns/types, drop non-existent chains/pages tables, add wallet_profiles_labels
  • Enable contract events for Blast/Kaia/Mode/Mode Testnet/Monad Testnet; add Katana
  • Roles: add BI-token + audit-log permissions; SSO: any SAML 2.0 IdP; add audit log mention
  • Integrations: document Slack/webhook/email via Alerts

Web SDK examples: remove Blocknative/Porto/Farcaster cards; normalize Crossmint/Openfort/Angular labels to with-N format


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

Audit of docs against ../formono (features, API, MCP, CLI, SDK, data,
security, integrations) and fixes for inaccurate or missing content.

MCP
- Document Scale/Enterprise plan requirement + 403 troubleshooting
- Correct tool table to the real allow-list (drop wallet_profiles,
  top_custom_events; rename top_sources_metrics -> top_sources; add
  missing tools); group top_* tools together
- lifecycle/retention/frequency are first-class tools, not SQL-only

API
- Add Get Contract page (GET /v0/contracts/{chain}/{address}) + nav

Events / SDK
- Fix version "1" -> "0"; add transaction reverted status
- Restore flattened function args (function_args is emitted both nested
  and flattened) + explain the behavior
- Move address/user_id to top level in connect/disconnect/chain/
  signature/identify samples
- Add paid-attribution click IDs; fix mobile network_* context fields
- Remove non-existent signatureHash from web SDK example
- Refresh stale SDK versions; reframe page-event example to a DeFi flow

Features
- Reframe Funnels/Flows/Retention as chart types (not nav pages);
  rename "User Flow" chart -> "Flow"
- "Ask AI" -> "Ask Formo" across features and guides
- Audience Insights / Segments live on the Users page
- Alerts: webhook/Slack only (no Telegram/Email); User alerts gated
- Remove fabricated behavioral wallet labels; use real label categories
- Holdings tab -> Apps/Tokens

Data / Chains / Security / Integrations
- Remove unimplemented linear (multi-touch) attribution
- Catalog: real columns/types, drop non-existent chains/pages tables,
  add wallet_profiles_labels
- Enable contract events for Blast/Kaia/Mode/Mode Testnet/Monad Testnet;
  add Katana
- Roles: add BI-token + audit-log permissions; SSO: any SAML 2.0 IdP;
  add audit log mention
- Integrations: document Slack/webhook/email via Alerts

Web SDK examples: remove Blocknative/Porto/Farcaster cards; normalize
Crossmint/Openfort/Angular labels to with-N format

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extensively updates the documentation to reflect product rebranding (renaming 'Ask AI' to 'Ask Formo'), navigation adjustments, and the introduction of Model Context Protocol (MCP) plan requirements. Technical updates include moving 'address' and 'user_id' to top-level event properties, adding ad click identifiers, and reorganizing wallet profile sections. Feedback identifies a contradiction regarding email alert support and highlights a loss of descriptive context in several SDK examples. A suggestion was also provided to improve the logical grouping of tools within the MCP documentation.

Comment thread integrations/overview.mdx
|:---------|:----------|:--------|
| Slack | ✅ | Posts formatted event cards to a Slack channel via an incoming webhook URL |
| Webhooks | ✅ | Sends matched events as JSON to your endpoint. |
| Email | ✅ | Sends alert notifications to one or more email recipients |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This entry contradicts the PR description and changes in other files (e.g., features/product-analytics/alerts.mdx and guides/funnels.mdx) which indicate that Email support for Alerts has been removed. If Email is indeed not supported, this row should be removed to avoid misleading users.

Comment thread sdks/web.mdx
href="https://github.com/getformo/examples/tree/main/with-crossmint"
>
Next.js + Crossmint embedded smart wallets. Manual Formo instrumentation (no EIP-1193 / wagmi).
examples/with-crossmint

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The descriptive text for the Crossmint example has been replaced with just the directory path. This results in a loss of helpful context for users (e.g., mentioning Next.js and manual instrumentation). Consider restoring the descriptive text.

    Next.js + Crossmint embedded smart wallets. Manual Formo instrumentation (no EIP-1193 / wagmi).

Comment thread sdks/web.mdx
href="https://github.com/getformo/examples/tree/main/with-openfort"
>
Vite + React + Openfort with Shield encryption sessions (Express backend) and an Aave supply/withdraw demo.
examples/with-openfort

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The descriptive text for the Openfort example has been replaced with just the directory path. Consider restoring the original description to maintain documentation quality.

    Vite + React + Openfort with Shield encryption sessions (Express backend) and an Aave supply/withdraw demo.

Comment thread sdks/web.mdx
href="https://github.com/getformo/examples/tree/main/with-farcaster"
>
examples/with-farcaster
examples/with-angular

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The descriptive text for the Angular example has been replaced with just the directory path. Consider restoring the original description.

    Angular 21 + bare EIP-1193 + viem. Uses the framework-agnostic SDK core.

Comment thread mcp/overview.mdx
Comment on lines 85 to +94
| `top_events` | View most common events |
| `top_custom_events` | View custom tracked events |
| `event_timeseries` | Event counts over time |
| `lifecycle` | New, returning, resurrected, and dormant users |
| `retention` | User retention by cohort |
| `frequency` | How often users return |
| `top_pages` | Analyze page performance |
| `top_sources_metrics` | Attribution and traffic sources |
| `top_sources` | Attribution and traffic sources |
| `top_locations` | Geographic distribution |
| `top_wallets` | Most active wallets |
| `top_chains` | Activity by blockchain |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions grouping top_* tools together, but top_events (line 85) is currently separated from top_pages (line 90) and the subsequent top_* tools by other analytics endpoints. Moving top_events down to be adjacent to top_pages would improve the logical grouping and consistency with the PR's intent.

Broken links/anchors (verified all internal links + heading anchors now
resolve, 0 broken):
- intro: /guides/ -> /guides/onchain-attribution
- custom-events: /features/wallet-intelligence -> .../overview;
  /sdks/web#custom-events -> #track-events
- sdks (web/server/mobile): /data/events#events-api ->
  /data/events/overview#events-api
- sdks/web + install: fix #react--nextjs / #websites / #privy /
  #react-&-next-js-without-wagmi anchors; install method links now point
  to the real /sdks/web#... headings
- metrics: custom-events#tracking-revenue -> #step-3-...; track comma anchor
- wallet-intelligence/overview, security/overview: drop dead anchors

Typos:
- metrics: "leave" -> "leaves"; "a search engines" -> "a search engine"
- what-we-collect: "the their time zone" -> "their time zone"
- chains: "on Ethereum on all major EVM chains" -> "and all major EVM chains"

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@yosriady yosriady merged commit 4c0c9eb into main May 21, 2026
4 checks passed
@yosriady yosriady deleted the docs/accuracy-audit-fixes branch May 21, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant