Fix persistent storage check that was defeated by MemoryStorage fallback

StorageManager.getStorage("asyncStorage") silently falls back to
MemoryStorage when AsyncStorage hasn't been initialized, and
MemoryStorage.isAvailable() always returns true. This made the
lifecycle guard ineffective — install events would still fire on
every cold start without AsyncStorage.

Fix: Add StorageManager.hasPersistentStorage() that checks if an
initialized AsyncStorage adapter exists in the storages map, bypassing
the fallback logic in getStorage().

https://claude.ai/code/session_0117WwRELH1nzVbxRj7Kmm5N

Author: claude

src/__tests__/lifecycle.test.ts

@@ -19,12 +19,8 @@ const mockStorageInstance = {
   isAvailable: jest.fn().mockReturnValue(true),
 };
 
-const mockAsyncStorageInstance = {
-  isAvailable: jest.fn().mockReturnValue(true),
-};
-
 const mockStorageManager = {
-  getStorage: jest.fn().mockReturnValue(mockAsyncStorageInstance),
+  hasPersistentStorage: jest.fn().mockReturnValue(true),
 };
 
 jest.mock('../lib/storage', () => ({
@@ -56,8 +52,7 @@ describe('AppLifecycleManager', () => {
     mockAnalytics = { track: jest.fn().mockResolvedValue(undefined) };
     mockStorageInstance.get.mockReturnValue(null);
     mockStorageInstance.set.mockReturnValue(undefined);
-    mockAsyncStorageInstance.isAvailable.mockReturnValue(true);
-    mockStorageManager.getStorage.mockReturnValue(mockAsyncStorageInstance);
+    mockStorageManager.hasPersistentStorage.mockReturnValue(true);
     (storage as jest.Mock).mockReturnValue(mockStorageInstance);
     (getStorageManager as jest.Mock).mockReturnValue(mockStorageManager);
     (AppState.addEventListener as jest.Mock).mockReturnValue({ remove: jest.fn() });
@@ -229,7 +224,7 @@ describe('AppLifecycleManager', () => {
 
   describe('no persistent storage', () => {
     it('should skip install/update detection when AsyncStorage is not available', async () => {
-      mockAsyncStorageInstance.isAvailable.mockReturnValue(false);
+      mockStorageManager.hasPersistentStorage.mockReturnValue(false);
 
       await manager.start({ version: '1.0.0', build: '1' });
 
@@ -244,7 +239,7 @@ describe('AppLifecycleManager', () => {
     });
 
     it('should still fire Application Opened without persistent storage', async () => {
-      mockAsyncStorageInstance.isAvailable.mockReturnValue(false);
+      mockStorageManager.hasPersistentStorage.mockReturnValue(false);
 
       await manager.start({ version: '1.0.0', build: '1' });
 

src/lib/lifecycle/index.ts

@@ -125,9 +125,7 @@ export class AppLifecycleManager {
    */
   private async detectInstallOrUpdate(): Promise<void> {
     const manager = getStorageManager();
-    const hasPersistentStorage = manager
-      ? manager.getStorage("asyncStorage").isAvailable()
-      : false;
+    const hasPersistentStorage = manager?.hasPersistentStorage() ?? false;
 
     if (!hasPersistentStorage) {
       logger.warn(

src/lib/storage/StorageManager.ts

@@ -75,6 +75,15 @@ export class StorageManager {
     }
     return this.getStorage("memoryStorage");
   }
+
+  /**
+   * Check if persistent storage (AsyncStorage) has been initialized.
+   * Returns false if only MemoryStorage is available.
+   */
+  public hasPersistentStorage(): boolean {
+    const stored = this.storages.get("asyncStorage");
+    return stored !== undefined && stored.isAvailable();
+  }
 }
 
 // Global storage manager instance