Await async storage persistence for app version to prevent duplicate install events

storage().set() writes to the in-memory cache synchronously but persists
to AsyncStorage asynchronously without being awaited. If the app crashes
or is force-quit before the async write completes, the version data is
lost and the next launch would fire a duplicate "Application Installed"
event. Switch to awaiting setAsync() to ensure persistence completes.

https://claude.ai/code/session_0117WwRELH1nzVbxRj7Kmm5N

Author: claude

src/__tests__/lifecycle.test.ts

@@ -15,6 +15,7 @@ jest.mock('react-native', () => ({
 const mockStorageInstance = {
   get: jest.fn().mockReturnValue(null),
   set: jest.fn(),
+  setAsync: jest.fn().mockResolvedValue(undefined),
   remove: jest.fn(),
   isAvailable: jest.fn().mockReturnValue(true),
 };
@@ -52,6 +53,7 @@ describe('AppLifecycleManager', () => {
     mockAnalytics = { track: jest.fn().mockResolvedValue(undefined) };
     mockStorageInstance.get.mockReturnValue(null);
     mockStorageInstance.set.mockReturnValue(undefined);
+    mockStorageInstance.setAsync.mockResolvedValue(undefined);
     mockStorageManager.hasPersistentStorage.mockReturnValue(true);
     (storage as jest.Mock).mockReturnValue(mockStorageInstance);
     (getStorageManager as jest.Mock).mockReturnValue(mockStorageManager);
@@ -89,8 +91,8 @@ describe('AppLifecycleManager', () => {
 
       await manager.start({ version: '1.0.0', build: '1' });
 
-      expect(mockStorageInstance.set).toHaveBeenCalledWith('app_version', '1.0.0');
-      expect(mockStorageInstance.set).toHaveBeenCalledWith('app_build', '1');
+      expect(mockStorageInstance.setAsync).toHaveBeenCalledWith('app_version', '1.0.0');
+      expect(mockStorageInstance.setAsync).toHaveBeenCalledWith('app_build', '1');
     });
   });
 

src/lib/lifecycle/index.ts

@@ -159,8 +159,10 @@ export class AppLifecycleManager {
     }
 
     // Persist current version/build for next comparison
-    storage().set(LOCAL_APP_VERSION_KEY, version);
-    storage().set(LOCAL_APP_BUILD_KEY, build);
+    // Use setAsync to ensure data is written to AsyncStorage before continuing,
+    // preventing duplicate install events if the app is terminated before persistence completes
+    await storage().setAsync(LOCAL_APP_VERSION_KEY, version);
+    await storage().setAsync(LOCAL_APP_BUILD_KEY, build);
   }
 
   /**