-
Notifications
You must be signed in to change notification settings - Fork 1
P-1525 React Native SDK #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 33 commits
320cd46
239fc7c
d2fe5aa
2760ad2
be619e2
610d344
fbb0953
29ee10e
08b75a5
235af1d
721af74
389ea2b
f4f90a7
ae27956
b30eef2
27c6836
5e04c24
f783740
abb689f
b3ea77f
8262340
5c8c95c
21d8f4b
151e8a3
3ef6db7
b5e3ea2
461249c
cd3668a
89bdafc
e8025f3
bbb5088
786f73f
a67ff3e
2e5d788
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, master] | ||
| pull_request: | ||
| branches: [main, master] | ||
|
|
||
| # Cancel in-progress runs when a new commit is pushed | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
|
|
||
| - name: Run type check | ||
| run: pnpm run typecheck | ||
|
|
||
| - name: Run tests with coverage | ||
| run: pnpm run test:coverage | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CI runs tests twice causing redundant executionLow Severity The CI workflow runs tests twice sequentially: first with |
||
|
|
||
| - name: Upload coverage reports | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| fail_ci_if_error: false | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| build: | ||
| runs-on: ubuntu-latest | ||
| needs: test | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --no-frozen-lockfile | ||
|
|
||
| - name: Build | ||
| run: pnpm run build | ||
|
|
||
| - name: Verify build output exists | ||
| run: | | ||
| test -d lib/commonjs || (echo "lib/commonjs not found" && exit 1) | ||
| test -d lib/module || (echo "lib/module not found" && exit 1) | ||
| test -d lib/typescript || (echo "lib/typescript not found" && exit 1) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| node_modules | ||
|
|
||
| # Build output (top-level lib/ directory only, not src/lib/) | ||
| /lib/ | ||
|
|
||
| # IDE | ||
| .idea/ | ||
| .vscode/ | ||
| *.swp | ||
| *.swo | ||
|
|
||
| # OS | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Test coverage | ||
| coverage/ | ||
|
|
||
| # Logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| # Environment | ||
| .env | ||
| .env.local | ||
| .env.*.local |


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI uses --no-frozen-lockfile allowing inconsistent builds
Low Severity
Using
pnpm install --no-frozen-lockfilein CI allows dependency versions to drift from what's specified in the lockfile. This can lead to non-reproducible builds where CI passes with different dependency versions than developers have locally, potentially masking bugs or introducing unexpected behavior.Additional Locations (1)
.github/workflows/ci.yml#L64-L65