Skip to content

P-2208: Harden github actions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 3 commits into from
May 21, 2026
Merged

P-2208: Harden github actions #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9507640
chore: harden GitHub Actions (P-2208)
keiloktql May 20, 2026
b6aeee7
fix(ci): remove redundant pnpm version pin from action-setup
keiloktql May 20, 2026
e539803
release: remove redundant zizmor cache-poisoning ignore
keiloktql May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ updates:
directory: "/"
schedule:
interval: "weekly"
cooldown:
default-days: 7
Comment on lines +7 to +8

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The cooldown property is not a supported configuration key in the official GitHub Dependabot schema. Including this key will cause a validation error, and Dependabot will fail to process updates for the github-actions ecosystem. If the intention is to delay updates to mitigate potential supply chain risks (e.g., waiting for a 'soak' period), Dependabot does not currently support this natively. You may need to use a third-party tool or adjust the schedule to achieve a similar effect.


- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "weekly"
open-pull-requests-limit: 10
cooldown:
default-days: 7
Comment on lines +15 to +16

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The cooldown property is not recognized by the Dependabot configuration parser. This will likely result in a 'Dependabot couldn't parse your .github/dependabot.yml' error in the GitHub repository settings, preventing updates for the npm ecosystem. It is recommended to remove these lines to ensure the configuration remains valid.

8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand Down Expand Up @@ -45,6 +47,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand All @@ -66,6 +70,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand All @@ -90,6 +96,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Setup pnpm
uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0 # Fetch all history for changelog generation
persist-credentials: false

- name: Verify tag is on main branch
env:
Expand All @@ -40,8 +41,8 @@ jobs:
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "22.14.0"
cache: 'pnpm'
# No registry-url - using OIDC trusted publishing instead
# No cache - mitigates cache-poisoning risk in publish workflow

- name: Update npm for trusted publishing
run: npm install -g npm@latest
Expand Down Expand Up @@ -111,7 +112,7 @@ jobs:
echo "Generating changelog from $PREV_TAG to $GITHUB_REF_NAME"
# Extract commits with PR numbers and format them
# Use tab as delimiter to safely handle semicolons and special characters
COMMITS=$(git log ${PREV_TAG}..HEAD --pretty=format:"%s %h" --no-merges)
COMMITS=$(git log "${PREV_TAG}..HEAD" --pretty=format:"%s %h" --no-merges)
else
echo "No previous tag found, using all commits"
COMMITS=$(git log --pretty=format:"%s %h" --no-merges)
Expand Down