fix(events): Cache counter for GET /events

Author: vincent-pochet

app/controllers/api/v1/events_controller.rb

@@ -83,7 +83,12 @@ def index
               result.events,
               ::V1::EventSerializer,
               collection_name: "events",
-              meta: pagination_metadata(result.events)
+              meta: pagination_metadata(
+                result.events,
+                key: "events",
+                organization_id: current_organization.id,
+                params: index_filters.merge(page: params[:page], per_page: params[:per_page])
+              )
             )
           )
         else
@@ -109,7 +114,12 @@ def index_enriched
               result.events,
               ::V1::EventEnrichedSerializer,
               collection_name: "events",
-              meta: pagination_metadata(result.events)
+              meta: pagination_metadata(
+                result.events,
+                key: "events_enriched",
+                organization_id: current_organization.id,
+                params: index_filters.merge(page: params[:page], per_page: params[:per_page])
+              )
             )
           )
         else

app/models/metadata/item_metadata.rb

@@ -45,13 +45,13 @@ def value_correctness
 # Table name: item_metadata
 # Database name: primary
 #
-#  id                                             :uuid             not null, primary key
-#  owner_type(Polymorphic owner type)             :string           not null
-#  value(item_metadata key-value pairs)           :jsonb            not null
-#  created_at                                     :datetime         not null
-#  updated_at                                     :datetime         not null
-#  organization_id(Reference to the organization) :uuid             not null
-#  owner_id(Polymorphic owner id)                 :uuid             not null
+#  id              :uuid             not null, primary key
+#  owner_type      :string           not null
+#  value           :jsonb            not null
+#  created_at      :datetime         not null
+#  updated_at      :datetime         not null
+#  organization_id :uuid             not null
+#  owner_id        :uuid             not null
 #
 # Indexes
 #

spec/requests/api/v1/events_controller_spec.rb

@@ -275,6 +275,25 @@
       end
     end
 
+    context "with unknown params", cache: :memory do
+      let(:params) { {page: 1, per_page: 1} }
+
+      before { create(:event, organization:) }
+
+      it "ignores unknown params for caching" do
+        # First request populates the cache
+        get_with_token(organization, "/api/v1/events", page: 1, per_page: 1)
+        expect(json[:meta][:total_count]).to eq(2)
+
+        # Add a third event
+        create(:event, organization:)
+
+        # Request with unknown param should return cached count (2), not fresh count (3)
+        get_with_token(organization, "/api/v1/events", page: 1, per_page: 1, unknown_param: "value")
+        expect(json[:meta][:total_count]).to eq(2)
+      end
+    end
+
     context "with code" do
       let(:params) { {code: event.code} }