fix: remove the unique index from the PR

Author: endenis

app/models/subscription.rb

@@ -353,7 +353,6 @@ def last_subscription_fee
 #  index_subscriptions_on_external_id                          (external_id)
 #  index_subscriptions_on_last_received_event_on               (last_received_event_on)
 #  index_subscriptions_on_last_received_event_on_null          (id) WHERE (last_received_event_on IS NULL)
-#  index_subscriptions_on_org_external_id_active               (organization_id,external_id) UNIQUE WHERE ((status = 1) AND ((created_at >= '2026-05-20 00:00:00'::timestamp without time zone) OR (activated_at >= '2026-05-20 00:00:00'::timestamp without time zone)))
 #  index_subscriptions_on_organization_id                      (organization_id)
 #  index_subscriptions_on_payment_method_id                    (payment_method_id)
 #  index_subscriptions_on_plan_id                              (plan_id)

db/migrate/20260520140601_add_unique_index_on_subscriptions_org_external_id_active.rb

@@ -393,7 +393,6 @@ DROP INDEX IF EXISTS public.index_subscriptions_on_previous_subscription_id_and_
 DROP INDEX IF EXISTS public.index_subscriptions_on_plan_id;
 DROP INDEX IF EXISTS public.index_subscriptions_on_payment_method_id;
 DROP INDEX IF EXISTS public.index_subscriptions_on_organization_id;
-DROP INDEX IF EXISTS public.index_subscriptions_on_org_external_id_active;
 DROP INDEX IF EXISTS public.index_subscriptions_on_last_received_event_on_null;
 DROP INDEX IF EXISTS public.index_subscriptions_on_last_received_event_on;
 DROP INDEX IF EXISTS public.index_subscriptions_on_external_id;
@@ -9319,13 +9318,6 @@ CREATE INDEX index_subscriptions_on_last_received_event_on ON public.subscriptio
 CREATE INDEX index_subscriptions_on_last_received_event_on_null ON public.subscriptions USING btree (id) WHERE (last_received_event_on IS NULL);
 
 
---
--- Name: index_subscriptions_on_org_external_id_active; Type: INDEX; Schema: public; Owner: -
---
-
-CREATE UNIQUE INDEX index_subscriptions_on_org_external_id_active ON public.subscriptions USING btree (organization_id, external_id) WHERE ((status = 1) AND ((created_at >= '2026-05-20 00:00:00'::timestamp without time zone) OR (activated_at >= '2026-05-20 00:00:00'::timestamp without time zone)));
-
-
 --
 -- Name: index_subscriptions_on_organization_id; Type: INDEX; Schema: public; Owner: -
 --
@@ -12222,7 +12214,6 @@ ALTER TABLE ONLY public.membership_roles
 SET search_path TO "$user", public;
 
 INSERT INTO "schema_migrations" (version) VALUES
-('20260520140601'),
 ('20260520075420'),
 ('20260517101105'),
 ('20260513105210'),

db/structure.sql

@@ -1119,45 +1119,4 @@
       end
     end
   end
-
-  describe "unique index on active subscriptions" do
-    # We skip model validations in this test in order to check that database unique index is applied
-
-    let(:organization) { create(:organization) }
-    let(:external_id) { SecureRandom.uuid }
-
-    context "when two new active subscriptions share the same (organization_id, external_id)" do
-      before do
-        create(:subscription, customer: create(:customer, organization:), external_id:)
-      end
-
-      it "raises a database uniqueness error" do
-        duplicate_sub = build(:subscription, customer: create(:customer, organization:), external_id:)
-
-        expect { duplicate_sub.save(validate: false) }.to raise_error(ActiveRecord::RecordNotUnique)
-      end
-    end
-
-    context "when two old pending subscriptions created before the index cutoff are activated after deploy" do
-      let(:sub_a) do
-        build(:subscription, :pending, customer: create(:customer, organization:), external_id:, created_at: 2.years.ago)
-      end
-      let(:sub_b) do
-        build(:subscription, :pending, customer: create(:customer, organization:), external_id:, created_at: 2.years.ago)
-      end
-
-      # rubocop:disable Rails/SkipsModelValidations
-      it "raises a database uniqueness error on the second activation" do
-        sub_a.save(validate: false)
-        sub_b.save(validate: false)
-
-        sub_a.update_columns(status: described_class.statuses[:active], activated_at: Time.current)
-
-        expect {
-          sub_b.update_columns(status: described_class.statuses[:active], activated_at: Time.current)
-        }.to raise_error(ActiveRecord::RecordNotUnique)
-      end
-      # rubocop:enable Rails/SkipsModelValidations
-    end
-  end
 end