feat(presentation_group_keys): Change invoice fee object to return only displayable in invoice presentation breakdowns#5539
Merged
Conversation
tiagolupepic
force-pushed
the
fix/change-fee-object-invoice-to-use-displayable-presentation-breakdowns
branch
from
May 19, 2026 17:33
2d63008 to
bfbfbad
Compare
displayable in invoice presentation breakdowns This commit changes the Fees::Object to filter only the presentation_breakdowns where the display_in_invoice of charge is true. We're also doing a refactor in FeeDisplayHelper to avoid repeat the same option to filter out the presentation breakdowns are not available in invoice. Having this, we have the logic centralised in Fee and the FeeDisplayHelper is calling the methods responsible to provide the presentation_breakdowns.
tiagolupepic
force-pushed
the
fix/change-fee-object-invoice-to-use-displayable-presentation-breakdowns
branch
3 times, most recently
from
May 21, 2026 10:01
a63e07b to
0c15f8f
Compare
… instead of the value Also, sum the presentation_breakdowns when exist duplicated keys
tiagolupepic
force-pushed
the
fix/change-fee-object-invoice-to-use-displayable-presentation-breakdowns
branch
from
May 21, 2026 10:02
0c15f8f to
4094cb4
Compare
tiagolupepic
merged commit May 27, 2026
6698dec
into
feat/presentation-breakdowns-in-pdf-invoices
12 checks passed
tiagolupepic
deleted the
fix/change-fee-object-invoice-to-use-displayable-presentation-breakdowns
branch
May 27, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the Fees::Object to filter only the presentation_breakdowns where the display_in_invoice of charge is true.
We're also doing a refactor in FeeDisplayHelper to avoid repeat the same option to filter out the presentation breakdowns are not available in invoice.
Having this, we have the logic centralized in Fee and the FeeDisplayHelper is calling the methods responsible to provide the presentation_breakdowns.