misc(clickhouse): Define primary key for events_enriched table#5555
Merged
Conversation
vincent-pochet
force-pushed
the
misc-events-enriched-pk
branch
from
May 21, 2026 15:00
5a3b1af to
45a419f
Compare
vincent-pochet
changed the title
toommz
reviewed
May 22, 2026
groyoh
approved these changes
May 22, 2026
groyoh
left a comment
groyoh
left a comment
Contributor
There was a problem hiding this comment.
Let's add a simple test to ensure no regression 🙏
vincent-pochet
force-pushed
the
misc-events-enriched-pk
branch
from
May 22, 2026 12:57
45a419f to
3459d02
Compare
toommz
approved these changes
May 22, 2026
D1353L
pushed a commit
that referenced
this pull request
May 26, 2026
## Description This PR sets the `primary_key` attribute for `events_enriched` and `events_enriched_expanded` tables. These two tables does not define a primary key and this change allows us to use `in_batch` AR method with a `cursor` to loop over rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the
primary_keyattribute forevents_enrichedandevents_enriched_expandedtables.These two tables does not define a primary key and this change allows us to use
in_batchAR method with acursorto loop over rows.