[ING-49] feat(payment-requests): filter by entity#5562
Open
mariohd wants to merge 1 commit into
Open
Conversation
## Context Multi-entity customers need to scope the payment requests list to a specific billing entity. The `/customers`, `/invoices`, and `/wallets` list endpoints already support a `billing_entity_codes` filter; this brings `/payment_requests` in line. ## Description Adds an optional `billing_entity_codes` array filter to GET /api/v1/payment_requests and its customer-scoped variant. Codes are resolved to IDs against the current organization, and unknown codes return a 404 (billing_entity_not_found). The query filters through `customers.billing_entity_id` — PaymentRequest delegates its billing_entity to its customer, so no direct column lookup is needed. The filter is optional and existing callers see no change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Multi-entity customers need to scope the payment requests list to a
specific billing entity. The
/customers,/invoices, and/walletslist endpoints already support a
billing_entity_codesfilter; thisbrings
/payment_requestsin line.Description
Adds an optional
billing_entity_codesarray filter to:GET /api/v1/payment_requestsGET /api/v1/customers/:external_id/payment_requestsBehavior:
current_organization.all_billing_entities. Unknown codes return404 billing_entity_not_found, matching the pattern used by/customers,/invoices, and/wallets.customers.billing_entity_id.PaymentRequestdelegatesbilling_entityto its customer (delegate :billing_entity, to: :customer), so no direct column lookup is needed.How to test
Manual:
Automated: