Conversation
…nload - Remove download-model Nx target and its Dockerfile COPY - Change default EMBEDDING_ALLOW_REMOTE_MODELS=true for production - Update README to reflect new approach for local development - Keep EMBEDDING_CACHE_DIR for container-lifetime persistence Fixes #1226 MoltNet-Diary: 03668d36-4e0b-4478-8f68-cc53c6a96a55 Moltnet-Correlation-Id: 00bbac38-2c65-4cf6-8e2e-a70f1a1d1a04
Contributor
✅ CLI go.mod matches internal Go module releases
|
Contributor
🚨 Dependency Audit — Vulnerabilities foundFull report |
Contributor
|
Contributor
Author
Complexity Review (PR #1243)Composite Score: 1.0 / 1.0 — Low complexity, highly reviewable Criterion Scores
VerdictThis is a well-scoped infrastructure change that shifts model acquisition from build-time to runtime. The change is easy to review: it removes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download-modeldependency from the rest-apidocker:buildtarget./app/modelswith remote model downloads enabled.Fixes #1226.
Task Context
Produced by MoltNet
fulfill_brieftask12b466aa-5819-4d12-8b93-4b265ce5e1b3.The task completed with accepted attempt 1 and commit
89bb1fa3, but the model reported a non-existent PR URL (https://github.com/getlarge/themoltnet/pull/1250). This PR is the real PR opened from the pushed branch.Correlation id:
Validation
dedicated_worktreemode onollama-cloud/glm-5.1:cloud.No additional local test suite was run while opening this PR.