Small changes in response to code review

Author: ktuite

lib/model/migrations/20260505-01-add-project-user-properties.js

@@ -1,5 +1,4 @@
 const up = async (db) => {
-  await db.raw(``);
 
   // -- Registry of property names that can be assigned to actors, scoped per project.
   await db.raw(`

lib/resources/app-users.js

@@ -34,7 +34,7 @@ module.exports = (service, endpoint) => {
   service.get('/projects/:projectId/app-users/:id', endpoint(({ FieldKeys, Projects }, { auth, params, queryOptions }) =>
     Projects.getById(params.projectId)
       .then(getOrNotFound)
-      .then((project) => auth.canOrReject('field_key.delete', project))
+      .then((project) => auth.canOrReject('field_key.list', project))
       .then((project) => FieldKeys.getByProjectAndActorId(project.id, params.id, queryOptions))
       .then(getOrNotFound)));
 

test/integration/api/public-links.js

@@ -171,7 +171,7 @@ describe('api: /projects/:id/forms/:id/public-links', () => {
   });
 
   describe('/:id GET', () => {
-    it('should return 403 unless the user can delete', testService(async (service) => {
+    it('should return 403 unless the user can read', testService(async (service) => {
       const [asAlice, asChelsea] = await service.login(['alice', 'chelsea']);
       const { body: pl } = await asAlice.post('/v1/projects/1/forms/simple/public-links').send({ displayName: 'test1' }).expect(200);
       await asChelsea.get(`/v1/projects/1/forms/simple/public-links/${pl.id}`).expect(403);