Skip to content

Commit ff9e749

Browse files
authored
test: bind ExpressJS servers to localhost (#1845)
Prevents these test services being exposed to external network requests.
1 parent e3d0ea9 commit ff9e749

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

test/e2e/oidc/fake-oidc-server/index.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ const oidc = new Provider(rootUrl, {
106106
const key = fs.readFileSync('../certs/fake-oidc-server.example.net-key.pem', 'utf8'); // eslint-disable-line no-multi-spaces
107107
const cert = fs.readFileSync('../certs/fake-oidc-server.example.net.pem', 'utf8');
108108
const httpsServer = https.createServer({ key, cert }, oidc.callback());
109-
await httpsServer.listen(port);
109+
await httpsServer.listen(port, '127.0.0.1');
110110
} else {
111-
await oidc.listen(port);
111+
await oidc.listen(port, '127.0.0.1');
112112
}
113113
log(`oidc-provider listening on port ${port}, check ${rootUrl}/.well-known/openid-configuration`);
114114
})();

test/e2e/oidc/playwright-tests/src/global-setup-teardown.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ async function startFakeFrontend() {
3434
fakeFrontend.get('*', successHandler); // eslint-disable-line no-use-before-define
3535

3636
if (frontendUrl.startsWith('http://')) {
37-
return fakeFrontend.listen(port);
37+
return fakeFrontend.listen(port, '127.0.0.1');
3838
} else {
3939
const fs = require('node:fs');
4040
const https = require('node:https');
4141
const key = fs.readFileSync('../certs/odk-central.example.org-key.pem', 'utf8');
4242
const cert = fs.readFileSync('../certs/odk-central.example.org.pem', 'utf8');
4343
const httpsServer = https.createServer({ key, cert }, fakeFrontend);
44-
await httpsServer.listen(port);
44+
await httpsServer.listen(port, '127.0.0.1');
4545
return httpsServer;
4646
}
4747
}

test/integration/external/sentry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('sentry', () => {
7979
res.send({ id: uuid().replace(/-/g, '') });
8080
});
8181

82-
const _server = app.listen(0, () => {
82+
const _server = app.listen(0, '127.0.0.1', () => {
8383
resolve(_server);
8484
});
8585
_server.on('error', reject);

0 commit comments

Comments
 (0)